From 9a0837593a452d32584f2309cf8328b6e15d0730 Mon Sep 17 00:00:00 2001
From: Thomas55555 <59625598+Thomas55555@users.noreply.github.com>
Date: Mon, 17 Mar 2025 17:38:40 +0100
Subject: [PATCH] Improve test coverage and add comment for loading in executor
 for remote calendar (#140807)

Improve calendar loading by executing in a separate thread and add test for CalendarParseError
---
 .../components/remote_calendar/coordinator.py       |  3 +++
 tests/components/remote_calendar/test_init.py       | 13 +++++++++++++
 2 files changed, 16 insertions(+)

diff --git a/homeassistant/components/remote_calendar/coordinator.py b/homeassistant/components/remote_calendar/coordinator.py
index 7ee95695e61..7f29f7e2ea8 100644
--- a/homeassistant/components/remote_calendar/coordinator.py
+++ b/homeassistant/components/remote_calendar/coordinator.py
@@ -56,6 +56,9 @@ class RemoteCalendarDataUpdateCoordinator(DataUpdateCoordinator[Calendar]):
                 translation_placeholders={"err": str(err)},
             ) from err
         try:
+            # calendar_from_ics will dynamically load packages
+            # the first time it is called, so we need to do it
+            # in a separate thread to avoid blocking the event loop
             return await self.hass.async_add_executor_job(
                 IcsCalendarStream.calendar_from_ics, res.text
             )
diff --git a/tests/components/remote_calendar/test_init.py b/tests/components/remote_calendar/test_init.py
index 08f5c8b45c0..f4ca500b2e1 100644
--- a/tests/components/remote_calendar/test_init.py
+++ b/tests/components/remote_calendar/test_init.py
@@ -71,3 +71,16 @@ async def test_update_failed(
     respx.get(CALENDER_URL).mock(side_effect=side_effect)
     await setup_integration(hass, config_entry)
     assert config_entry.state is ConfigEntryState.SETUP_RETRY
+
+
+@respx.mock
+async def test_calendar_parse_error(
+    hass: HomeAssistant,
+    config_entry: MockConfigEntry,
+) -> None:
+    """Test CalendarParseError using respx."""
+    respx.get(CALENDER_URL).mock(
+        return_value=Response(status_code=200, text="not a calendar")
+    )
+    await setup_integration(hass, config_entry)
+    assert config_entry.state is ConfigEntryState.SETUP_RETRY