Use ConfigEntry runtime_data in Garages Amsterdam (#131611)

This commit is contained in:
Klaas Schoute 2024-11-26 12:30:50 +01:00 committed by GitHub
parent 5da7b1dd05
commit 9a999e8742
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 14 additions and 25 deletions

View File

@ -9,7 +9,6 @@ from homeassistant.const import Platform
from homeassistant.core import HomeAssistant
from homeassistant.helpers.aiohttp_client import async_get_clientsession
from .const import DOMAIN
from .coordinator import GaragesAmsterdamDataUpdateCoordinator
PLATFORMS: list[Platform] = [Platform.BINARY_SENSOR, Platform.SENSOR]
@ -17,24 +16,23 @@ PLATFORMS: list[Platform] = [Platform.BINARY_SENSOR, Platform.SENSOR]
type GaragesAmsterdamConfigEntry = ConfigEntry[GaragesAmsterdamDataUpdateCoordinator]
async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
async def async_setup_entry(
hass: HomeAssistant, entry: GaragesAmsterdamConfigEntry
) -> bool:
"""Set up Garages Amsterdam from a config entry."""
client = ODPAmsterdam(session=async_get_clientsession(hass))
coordinator = GaragesAmsterdamDataUpdateCoordinator(hass, client)
await coordinator.async_config_entry_first_refresh()
hass.data.setdefault(DOMAIN, {})
hass.data[DOMAIN][entry.entry_id] = coordinator
entry.runtime_data = coordinator
await hass.config_entries.async_forward_entry_setups(entry, PLATFORMS)
return True
async def async_unload_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
async def async_unload_entry(
hass: HomeAssistant, entry: GaragesAmsterdamConfigEntry
) -> bool:
"""Unload Garages Amsterdam config entry."""
unload_ok = await hass.config_entries.async_unload_platforms(entry, PLATFORMS)
if len(hass.config_entries.async_entries(DOMAIN)) == 1:
hass.data.pop(DOMAIN)
return unload_ok
return await hass.config_entries.async_unload_platforms(entry, PLATFORMS)

View File

@ -6,12 +6,10 @@ from homeassistant.components.binary_sensor import (
BinarySensorDeviceClass,
BinarySensorEntity,
)
from homeassistant.config_entries import ConfigEntry
from homeassistant.core import HomeAssistant
from homeassistant.helpers.entity_platform import AddEntitiesCallback
from .const import DOMAIN
from .coordinator import GaragesAmsterdamDataUpdateCoordinator
from . import GaragesAmsterdamConfigEntry
from .entity import GaragesAmsterdamEntity
BINARY_SENSORS = {
@ -21,13 +19,11 @@ BINARY_SENSORS = {
async def async_setup_entry(
hass: HomeAssistant,
entry: ConfigEntry,
entry: GaragesAmsterdamConfigEntry,
async_add_entities: AddEntitiesCallback,
) -> None:
"""Defer sensor setup to the shared sensor module."""
coordinator: GaragesAmsterdamDataUpdateCoordinator = hass.data[DOMAIN][
entry.entry_id
]
coordinator = entry.runtime_data
async_add_entities(
GaragesAmsterdamBinarySensor(coordinator, entry.data["garage_name"], info_type)

View File

@ -3,11 +3,10 @@
from __future__ import annotations
from homeassistant.components.sensor import SensorEntity
from homeassistant.config_entries import ConfigEntry
from homeassistant.core import HomeAssistant
from homeassistant.helpers.entity_platform import AddEntitiesCallback
from .const import DOMAIN
from . import GaragesAmsterdamConfigEntry
from .coordinator import GaragesAmsterdamDataUpdateCoordinator
from .entity import GaragesAmsterdamEntity
@ -21,13 +20,11 @@ SENSORS = {
async def async_setup_entry(
hass: HomeAssistant,
entry: ConfigEntry,
entry: GaragesAmsterdamConfigEntry,
async_add_entities: AddEntitiesCallback,
) -> None:
"""Defer sensor setup to the shared sensor module."""
coordinator: GaragesAmsterdamDataUpdateCoordinator = hass.data[DOMAIN][
entry.entry_id
]
coordinator = entry.runtime_data
async_add_entities(
GaragesAmsterdamSensor(coordinator, entry.data["garage_name"], info_type)

View File

@ -2,7 +2,6 @@
from unittest.mock import AsyncMock
from homeassistant.components.garages_amsterdam.const import DOMAIN
from homeassistant.config_entries import ConfigEntryState
from homeassistant.core import HomeAssistant
@ -24,5 +23,4 @@ async def test_load_unload_config_entry(
await hass.config_entries.async_unload(mock_config_entry.entry_id)
await hass.async_block_till_done()
assert not hass.data.get(DOMAIN)
assert mock_config_entry.state is ConfigEntryState.NOT_LOADED