From 9ae0cfc7e591a2f3a8d7a35793fa320e0c250ae0 Mon Sep 17 00:00:00 2001 From: Joost Lekkerkerker Date: Mon, 16 Jun 2025 18:23:20 +0200 Subject: [PATCH] Create entities directly on setup in Meater (#146953) * Don't wait an update when adding devices in Meater * Fix --- homeassistant/components/meater/sensor.py | 1 + tests/components/meater/snapshots/test_sensor.ambr | 4 ++-- tests/components/meater/test_init.py | 8 +------- tests/components/meater/test_sensor.py | 9 +-------- 4 files changed, 5 insertions(+), 17 deletions(-) diff --git a/homeassistant/components/meater/sensor.py b/homeassistant/components/meater/sensor.py index f7a746c923f..ee6056e0ddc 100644 --- a/homeassistant/components/meater/sensor.py +++ b/homeassistant/components/meater/sensor.py @@ -170,6 +170,7 @@ async def async_setup_entry( # Add a subscriber to the coordinator to discover new temperature probes coordinator.async_add_listener(async_update_data) + async_update_data() class MeaterProbeTemperature(SensorEntity, CoordinatorEntity[MeaterCoordinator]): diff --git a/tests/components/meater/snapshots/test_sensor.ambr b/tests/components/meater/snapshots/test_sensor.ambr index 954dbf8b138..268f972b716 100644 --- a/tests/components/meater/snapshots/test_sensor.ambr +++ b/tests/components/meater/snapshots/test_sensor.ambr @@ -303,7 +303,7 @@ 'last_changed': , 'last_reported': , 'last_updated': , - 'state': '2023-10-20T23:59:58+00:00', + 'state': '2023-10-20T23:59:28+00:00', }) # --- # name: test_entities[sensor.meater_40a72384fa80349314dfd97c84b73a5c1c9da57b59e26d67b573d618fe0d6e58_cook_time_remaining-entry] @@ -351,7 +351,7 @@ 'last_changed': , 'last_reported': , 'last_updated': , - 'state': '2023-10-21T00:01:02+00:00', + 'state': '2023-10-21T00:00:32+00:00', }) # --- # name: test_entities[sensor.meater_40a72384fa80349314dfd97c84b73a5c1c9da57b59e26d67b573d618fe0d6e58_internal-entry] diff --git a/tests/components/meater/test_init.py b/tests/components/meater/test_init.py index 52fb73ffdd8..52f6b29d488 100644 --- a/tests/components/meater/test_init.py +++ b/tests/components/meater/test_init.py @@ -1,9 +1,7 @@ """Tests for the Meater integration.""" -from datetime import timedelta from unittest.mock import AsyncMock -from freezegun.api import FrozenDateTimeFactory from syrupy.assertion import SnapshotAssertion from homeassistant.components.meater.const import DOMAIN @@ -13,7 +11,7 @@ from homeassistant.helpers import device_registry as dr from . import setup_integration from .const import PROBE_ID -from tests.common import MockConfigEntry, async_fire_time_changed +from tests.common import MockConfigEntry async def test_device_info( @@ -22,13 +20,9 @@ async def test_device_info( mock_meater_client: AsyncMock, mock_config_entry: MockConfigEntry, device_registry: dr.DeviceRegistry, - freezer: FrozenDateTimeFactory, ) -> None: """Test device registry integration.""" await setup_integration(hass, mock_config_entry) - freezer.tick(timedelta(seconds=30)) - async_fire_time_changed(hass) - await hass.async_block_till_done() device_entry = device_registry.async_get_device(identifiers={(DOMAIN, PROBE_ID)}) assert device_entry is not None assert device_entry == snapshot diff --git a/tests/components/meater/test_sensor.py b/tests/components/meater/test_sensor.py index 7a39538b914..8ddd5fbb590 100644 --- a/tests/components/meater/test_sensor.py +++ b/tests/components/meater/test_sensor.py @@ -1,9 +1,7 @@ """Tests for the Meater sensors.""" -from datetime import timedelta from unittest.mock import AsyncMock, patch -from freezegun.api import FrozenDateTimeFactory import pytest from syrupy.assertion import SnapshotAssertion @@ -13,7 +11,7 @@ from homeassistant.helpers import entity_registry as er from . import setup_integration -from tests.common import MockConfigEntry, async_fire_time_changed, snapshot_platform +from tests.common import MockConfigEntry, snapshot_platform @pytest.mark.freeze_time("2023-10-21") @@ -23,14 +21,9 @@ async def test_entities( entity_registry: er.EntityRegistry, mock_meater_client: AsyncMock, mock_config_entry: MockConfigEntry, - freezer: FrozenDateTimeFactory, ) -> None: """Test the sensor entities.""" with patch("homeassistant.components.meater.PLATFORMS", [Platform.SENSOR]): await setup_integration(hass, mock_config_entry) - freezer.tick(timedelta(seconds=30)) - async_fire_time_changed(hass) - await hass.async_block_till_done() - await snapshot_platform(hass, entity_registry, snapshot, mock_config_entry.entry_id)