From 9b60b0c23f2b05377b9a44c9ca5e187407c0ab09 Mon Sep 17 00:00:00 2001
From: mletenay <mle@whitestein.com>
Date: Wed, 29 Jun 2022 06:09:24 +0200
Subject: [PATCH] Keep sum energy sensors always available (#69218)

---
 homeassistant/components/goodwe/sensor.py | 30 +++++++++++++++++------
 1 file changed, 23 insertions(+), 7 deletions(-)

diff --git a/homeassistant/components/goodwe/sensor.py b/homeassistant/components/goodwe/sensor.py
index 96a8ef49af3..6dcdc6e8cb1 100644
--- a/homeassistant/components/goodwe/sensor.py
+++ b/homeassistant/components/goodwe/sensor.py
@@ -3,7 +3,7 @@ from __future__ import annotations
 
 from collections.abc import Callable
 from dataclasses import dataclass
-from typing import Any
+from typing import Any, cast
 
 from goodwe import Inverter, Sensor, SensorKind
 
@@ -49,7 +49,7 @@ _MAIN_SENSORS = (
     "e_bat_discharge_total",
 )
 
-_ICONS = {
+_ICONS: dict[SensorKind, str] = {
     SensorKind.PV: "mdi:solar-power",
     SensorKind.AC: "mdi:power-plug-outline",
     SensorKind.UPS: "mdi:power-plug-off-outline",
@@ -62,10 +62,13 @@ _ICONS = {
 class GoodweSensorEntityDescription(SensorEntityDescription):
     """Class describing Goodwe sensor entities."""
 
-    value: Callable[[str, Any, Any], Any] = lambda sensor, prev, val: val
+    value: Callable[[Any, Any], Any] = lambda prev, val: val
+    available: Callable[
+        [CoordinatorEntity], bool
+    ] = lambda entity: entity.coordinator.last_update_success
 
 
-_DESCRIPTIONS = {
+_DESCRIPTIONS: dict[str, GoodweSensorEntityDescription] = {
     "A": GoodweSensorEntityDescription(
         key="A",
         device_class=SensorDeviceClass.CURRENT,
@@ -89,7 +92,8 @@ _DESCRIPTIONS = {
         device_class=SensorDeviceClass.ENERGY,
         state_class=SensorStateClass.TOTAL_INCREASING,
         native_unit_of_measurement=ENERGY_KILO_WATT_HOUR,
-        value=lambda sensor, prev, val: prev if "total" in sensor and not val else val,
+        value=lambda prev, val: prev if not val else val,
+        available=lambda entity: entity.coordinator.data is not None,
     ),
     "C": GoodweSensorEntityDescription(
         key="C",
@@ -167,10 +171,22 @@ class InverterSensor(CoordinatorEntity, SensorEntity):
     @property
     def native_value(self):
         """Return the value reported by the sensor."""
-        value = self.entity_description.value(
-            self._sensor.id_,
+        value = cast(GoodweSensorEntityDescription, self.entity_description).value(
             self._previous_value,
             self.coordinator.data.get(self._sensor.id_, self._previous_value),
         )
         self._previous_value = value
         return value
+
+    @property
+    def available(self) -> bool:
+        """Return if entity is available.
+
+        We delegate the behavior to entity description lambda, since
+        some sensors (like energy produced today) should report themselves
+        as available even when the (non-battery) pv inverter is off-line during night
+        and most of the sensors are actually unavailable.
+        """
+        return cast(GoodweSensorEntityDescription, self.entity_description).available(
+            self
+        )