From 9d9817328b735c7bc6f9fd4ad9aaf141bb8b3d03 Mon Sep 17 00:00:00 2001 From: GrahamJB1 <26122648+GrahamJB1@users.noreply.github.com> Date: Wed, 18 Jan 2023 07:49:38 +0000 Subject: [PATCH] Reset Modbus value on down (#86127) * modbus: slave should reset value on sensor down as parent does that * modbus: slave should reset value on sensor down as parent does that --- homeassistant/components/modbus/binary_sensor.py | 3 +-- homeassistant/components/modbus/sensor.py | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/homeassistant/components/modbus/binary_sensor.py b/homeassistant/components/modbus/binary_sensor.py index 1f88c72204e..f1f5814fe76 100644 --- a/homeassistant/components/modbus/binary_sensor.py +++ b/homeassistant/components/modbus/binary_sensor.py @@ -153,6 +153,5 @@ class SlaveSensor( def _handle_coordinator_update(self) -> None: """Handle updated data from the coordinator.""" result = self.coordinator.data - if result: - self._attr_is_on = bool(result[self._result_inx] & 1) + self._attr_is_on = bool(result[self._result_inx] & 1) if result else None super()._handle_coordinator_update() diff --git a/homeassistant/components/modbus/sensor.py b/homeassistant/components/modbus/sensor.py index 8141a4b26f1..7231f3e11a5 100644 --- a/homeassistant/components/modbus/sensor.py +++ b/homeassistant/components/modbus/sensor.py @@ -156,6 +156,5 @@ class SlaveSensor( def _handle_coordinator_update(self) -> None: """Handle updated data from the coordinator.""" result = self.coordinator.data - if result: - self._attr_native_value = result[self._idx] + self._attr_native_value = result[self._idx] if result else None super()._handle_coordinator_update()