jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-18 18:57:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace pop calls with del where the result is discarded in mqtt (#118338)

Browse Source
This commit is contained in:
J. Nick Koston 2024-05-28 15:26:35 -10:00 committed by GitHub
parent fd9d4dbb34
commit 9de066d9e1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
homeassistant/components/mqtt/debug_info.py
View File

@ -79,7 +79,7 @@ def remove_subscription(
subscriptions = debug_info_entities[entity_id]["subscriptions"] subscriptions = debug_info_entities[entity_id]["subscriptions"]
subscriptions[subscription]["count"] -= 1 subscriptions[subscription]["count"] -= 1
if not subscriptions[subscription]["count"]: if not subscriptions[subscription]["count"]:
subscriptions.pop(subscription) del subscriptions[subscription]
def add_entity_discovery_data( def add_entity_discovery_data(
@ -107,7 +107,7 @@ def update_entity_discovery_data(
def remove_entity_data(hass: HomeAssistant, entity_id: str) -> None: def remove_entity_data(hass: HomeAssistant, entity_id: str) -> None:
"""Remove discovery data.""" """Remove discovery data."""
if entity_id in (debug_info_entities := hass.data[DATA_MQTT].debug_info_entities): if entity_id in (debug_info_entities := hass.data[DATA_MQTT].debug_info_entities):
debug_info_entities.pop(entity_id) del debug_info_entities[entity_id]
def add_trigger_discovery_data( def add_trigger_discovery_data(
@ -138,7 +138,7 @@ def remove_trigger_discovery_data(
hass: HomeAssistant, discovery_hash: tuple[str, str] hass: HomeAssistant, discovery_hash: tuple[str, str]
) -> None: ) -> None:
"""Remove discovery data.""" """Remove discovery data."""
hass.data[DATA_MQTT].debug_info_triggers.pop(discovery_hash) del hass.data[DATA_MQTT].debug_info_triggers[discovery_hash]
def _info_for_entity(hass: HomeAssistant, entity_id: str) -> dict[str, Any]: def _info_for_entity(hass: HomeAssistant, entity_id: str) -> dict[str, Any]:

2
homeassistant/components/mqtt/tag.py
View File

@ -181,4 +181,4 @@ class MQTTTagScanner(MqttDiscoveryDeviceUpdateMixin):
self.hass, self._sub_state self.hass, self._sub_state
) )
if self.device_id: if self.device_id:
self.hass.data[DATA_MQTT].tags[self.device_id].pop(discovery_id) del self.hass.data[DATA_MQTT].tags[self.device_id][discovery_id]