jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-15 09:17:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Device tracker: SNMPv3 (#3961)

Browse Source 
* Add initial SNMPv3 support for better security

* Fixed indentation errors

* Fixed flake8 E128 on row 65

* Disabled warning about too many instance-attributes

* Removed extra code, added Inclusive to make better config validation
This commit is contained in:
Teemu Mikkonen 2016-10-21 09:01:30 +03:00 committed by Paulus Schoutsen
parent 62b8e54235
commit 9f6d1c4e7b
1 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
homeassistant/components/device_tracker/snmp.py
View File

@ -23,11 +23,17 @@ _LOGGER = logging.getLogger(__name__)
REQUIREMENTS = ['pysnmp==4.3.2'] REQUIREMENTS = ['pysnmp==4.3.2']
CONF_COMMUNITY = "community" CONF_COMMUNITY = "community"
CONF_AUTHKEY = "authkey"
CONF_PRIVKEY = "privkey"
CONF_BASEOID = "baseoid" CONF_BASEOID = "baseoid"
DEFAULT_COMMUNITY = "public"
PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({ PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({
vol.Required(CONF_HOST): cv.string, vol.Required(CONF_HOST): cv.string,
vol.Required(CONF_COMMUNITY): cv.string, vol.Optional(CONF_COMMUNITY, default=DEFAULT_COMMUNITY): cv.string,
vol.Inclusive(CONF_AUTHKEY, "keys"): cv.string,
vol.Inclusive(CONF_PRIVKEY, "keys"): cv.string,
vol.Required(CONF_BASEOID): cv.string vol.Required(CONF_BASEOID): cv.string
}) })
@ -43,13 +49,24 @@ def get_scanner(hass, config):
class SnmpScanner(object): class SnmpScanner(object):
"""Queries any SNMP capable Access Point for connected devices.""" """Queries any SNMP capable Access Point for connected devices."""
# pylint: disable=too-many-instance-attributes
def __init__(self, config): def __init__(self, config):
"""Initialize the scanner.""" """Initialize the scanner."""
from pysnmp.entity.rfc3413.oneliner import cmdgen from pysnmp.entity.rfc3413.oneliner import cmdgen
from pysnmp.entity import config as cfg
self.snmp = cmdgen.CommandGenerator() self.snmp = cmdgen.CommandGenerator()
self.host = cmdgen.UdpTransportTarget((config[CONF_HOST], 161)) self.host = cmdgen.UdpTransportTarget((config[CONF_HOST], 161))
self.community = cmdgen.CommunityData(config[CONF_COMMUNITY]) if CONF_AUTHKEY not in config or CONF_PRIVKEY not in config:
self.auth = cmdgen.CommunityData(config[CONF_COMMUNITY])
else:
self.auth = cmdgen.UsmUserData(
config[CONF_COMMUNITY],
config[CONF_AUTHKEY],
config[CONF_PRIVKEY],
authProtocol=cfg.usmHMACSHAAuthProtocol,
privProtocol=cfg.usmAesCfb128Protocol
)
self.baseoid = cmdgen.MibVariable(config[CONF_BASEOID]) self.baseoid = cmdgen.MibVariable(config[CONF_BASEOID])
self.lock = threading.Lock() self.lock = threading.Lock()
@ -95,7 +112,7 @@ class SnmpScanner(object):
devices = [] devices = []
errindication, errstatus, errindex, restable = self.snmp.nextCmd( errindication, errstatus, errindex, restable = self.snmp.nextCmd(
self.community, self.host, self.baseoid) self.auth, self.host, self.baseoid)
if errindication: if errindication:
_LOGGER.error("SNMPLIB error: %s", errindication) _LOGGER.error("SNMPLIB error: %s", errindication)