jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-29 16:17:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix lingering timer in rflink (#92460)

Browse Source
This commit is contained in:
epenet 2023-05-04 12:23:45 +02:00 committed by GitHub
parent b0b53574f9
commit 9fca594777
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
homeassistant/components/rflink/__init__.py
View File

@ -20,7 +20,7 @@ from homeassistant.const import (
EVENT_HOMEASSISTANT_STOP, EVENT_HOMEASSISTANT_STOP,
STATE_ON, STATE_ON,
) )
from homeassistant.core import CoreState, HomeAssistant, ServiceCall, callback from homeassistant.core import CoreState, HassJob, HomeAssistant, ServiceCall, callback
from homeassistant.exceptions import HomeAssistantError from homeassistant.exceptions import HomeAssistantError
import homeassistant.helpers.config_validation as cv import homeassistant.helpers.config_validation as cv
from homeassistant.helpers.dispatcher import ( from homeassistant.helpers.dispatcher import (
@ -28,6 +28,7 @@ from homeassistant.helpers.dispatcher import (
async_dispatcher_send, async_dispatcher_send,
) )
from homeassistant.helpers.entity import Entity from homeassistant.helpers.entity import Entity
from homeassistant.helpers.event import async_call_later
from homeassistant.helpers.restore_state import RestoreEntity from homeassistant.helpers.restore_state import RestoreEntity
from homeassistant.helpers.typing import ConfigType from homeassistant.helpers.typing import ConfigType
@ -246,7 +247,7 @@ async def async_setup(hass: HomeAssistant, config: ConfigType) -> bool:
) )
@callback @callback
def reconnect(exc=None): def reconnect(_: Exception | None = None) -> None:
"""Schedule reconnect after connection has been unexpectedly lost.""" """Schedule reconnect after connection has been unexpectedly lost."""
# Reset protocol binding before starting reconnect # Reset protocol binding before starting reconnect
RflinkCommand.set_rflink_protocol(None) RflinkCommand.set_rflink_protocol(None)
@ -258,6 +259,8 @@ async def async_setup(hass: HomeAssistant, config: ConfigType) -> bool:
_LOGGER.warning("Disconnected from Rflink, reconnecting") _LOGGER.warning("Disconnected from Rflink, reconnecting")
hass.async_create_task(connect()) hass.async_create_task(connect())
_reconnect_job = HassJob(reconnect, "Rflink reconnect", cancel_on_shutdown=True)
async def connect(): async def connect():
"""Set up connection and hook it into HA for reconnect/shutdown.""" """Set up connection and hook it into HA for reconnect/shutdown."""
_LOGGER.info("Initiating Rflink connection") _LOGGER.info("Initiating Rflink connection")
@ -284,7 +287,7 @@ async def async_setup(hass: HomeAssistant, config: ConfigType) -> bool:
SerialException, SerialException,
OSError, OSError,
asyncio.TimeoutError, asyncio.TimeoutError,
) as exc: ):
reconnect_interval = config[DOMAIN][CONF_RECONNECT_INTERVAL] reconnect_interval = config[DOMAIN][CONF_RECONNECT_INTERVAL]
_LOGGER.exception( _LOGGER.exception(
"Error connecting to Rflink, reconnecting in %s", reconnect_interval "Error connecting to Rflink, reconnecting in %s", reconnect_interval
@ -292,7 +295,7 @@ async def async_setup(hass: HomeAssistant, config: ConfigType) -> bool:
# Connection to Rflink device is lost, make entities unavailable # Connection to Rflink device is lost, make entities unavailable
async_dispatcher_send(hass, SIGNAL_AVAILABILITY, False) async_dispatcher_send(hass, SIGNAL_AVAILABILITY, False)
hass.loop.call_later(reconnect_interval, reconnect, exc) async_call_later(hass, reconnect_interval, _reconnect_job)
return return
# There is a valid connection to a Rflink device now so # There is a valid connection to a Rflink device now so