jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-22 20:57:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix goodwe export limit unit on single phase DT inverters (#90427)

Browse Source 
* Fix export limit unit on single phase DT inverters

* Update homeassistant/components/goodwe/number.py

---------

Co-authored-by: Erik Montnemery <erik@montnemery.com>
This commit is contained in:
mletenay 2023-03-29 16:01:14 +02:00 committed by GitHub
parent d427c35c87
commit a1c94919de
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
homeassistant/components/goodwe/manifest.json
View File

@ -6,5 +6,5 @@
"documentation": "https://www.home-assistant.io/integrations/goodwe", "documentation": "https://www.home-assistant.io/integrations/goodwe",
"iot_class": "local_polling", "iot_class": "local_polling",
"loggers": ["goodwe"], "loggers": ["goodwe"],
"requirements": ["goodwe==0.2.25"] "requirements": ["goodwe==0.2.29"]
} }

13
homeassistant/components/goodwe/number.py
View File

@ -39,8 +39,13 @@ class GoodweNumberEntityDescription(
"""Class describing Goodwe number entities.""" """Class describing Goodwe number entities."""
def _get_setting_unit(inverter: Inverter, setting: str) -> str:
"""Return the unit of an inverter setting."""
return next((s.unit for s in inverter.settings() if s.id_ == setting), "")
NUMBERS = ( NUMBERS = (
# non DT inverters (limit in W) # Export limit in W
GoodweNumberEntityDescription( GoodweNumberEntityDescription(
key="grid_export_limit", key="grid_export_limit",
name="Grid export limit", name="Grid export limit",
@ -53,9 +58,9 @@ NUMBERS = (
native_max_value=10000, native_max_value=10000,
getter=lambda inv: inv.get_grid_export_limit(), getter=lambda inv: inv.get_grid_export_limit(),
setter=lambda inv, val: inv.set_grid_export_limit(val), setter=lambda inv, val: inv.set_grid_export_limit(val),
filter=lambda inv: type(inv).__name__ != "DT", filter=lambda inv: _get_setting_unit(inv, "grid_export_limit") != "%",
), ),
# DT inverters (limit is in %) # Export limit in %
GoodweNumberEntityDescription( GoodweNumberEntityDescription(
key="grid_export_limit", key="grid_export_limit",
name="Grid export limit", name="Grid export limit",
@ -67,7 +72,7 @@ NUMBERS = (
native_max_value=100, native_max_value=100,
getter=lambda inv: inv.get_grid_export_limit(), getter=lambda inv: inv.get_grid_export_limit(),
setter=lambda inv, val: inv.set_grid_export_limit(val), setter=lambda inv, val: inv.set_grid_export_limit(val),
filter=lambda inv: type(inv).__name__ == "DT", filter=lambda inv: _get_setting_unit(inv, "grid_export_limit") == "%",
), ),
GoodweNumberEntityDescription( GoodweNumberEntityDescription(
key="battery_discharge_depth", key="battery_discharge_depth",

2
requirements_all.txt
View File

@ -798,7 +798,7 @@ glances_api==0.4.1
goalzero==0.2.1 goalzero==0.2.1
# homeassistant.components.goodwe # homeassistant.components.goodwe
goodwe==0.2.25 goodwe==0.2.29
# homeassistant.components.google_mail # homeassistant.components.google_mail
google-api-python-client==2.71.0 google-api-python-client==2.71.0

2
requirements_test_all.txt
View File

@ -614,7 +614,7 @@ glances_api==0.4.1
goalzero==0.2.1 goalzero==0.2.1
# homeassistant.components.goodwe # homeassistant.components.goodwe
goodwe==0.2.25 goodwe==0.2.29
# homeassistant.components.google_mail # homeassistant.components.google_mail
google-api-python-client==2.71.0 google-api-python-client==2.71.0