Dont add location entities without location scope in Teslemetry (#143497)

* Dont add location entities without location scope

* Fix tests

* simplify logic

* Add test

homeassistant/components/teslemetry/device_tracker.py

@@ -5,6 +5,7 @@ from __future__ import annotations
 from collections.abc import Callable
 from dataclasses import dataclass
 
+from tesla_fleet_api.const import Scope
 from teslemetry_stream import TeslemetryStreamVehicle
 from teslemetry_stream.const import TeslaLocation
 
@@ -75,6 +76,10 @@ async def async_setup_entry(
     entities: list[
         TeslemetryPollingDeviceTrackerEntity | TeslemetryStreamingDeviceTrackerEntity
     ] = []
+    # Only add vehicle location entities if the user has granted vehicle location scope.
+    if Scope.VEHICLE_LOCATION not in entry.runtime_data.scopes:
+        return
+
     for vehicle in entry.runtime_data.vehicles:
         for description in DESCRIPTIONS:
             if vehicle.api.pre2021 or vehicle.firmware < description.streaming_firmware:

tests/components/teslemetry/const.py

@@ -45,6 +45,7 @@ METADATA = {
         "vehicle_device_data",
         "vehicle_cmds",
         "vehicle_charging_cmds",
+        "vehicle_location",
         "energy_device_data",
         "energy_cmds",
     ],

tests/components/teslemetry/snapshots/test_diagnostics.ambr

@@ -191,6 +191,7 @@
       'vehicle_device_data',
       'vehicle_cmds',
       'vehicle_charging_cmds',
+      'vehicle_location',
       'energy_device_data',
       'energy_cmds',
     ]),

tests/components/teslemetry/test_device_tracker.py

@@ -11,7 +11,7 @@ from homeassistant.core import HomeAssistant
 from homeassistant.helpers import entity_registry as er
 
 from . import assert_entities, assert_entities_alt, setup_platform
-from .const import VEHICLE_DATA_ALT
+from .const import METADATA_NOSCOPE, VEHICLE_DATA_ALT
 
 
 @pytest.mark.usefixtures("entity_registry_enabled_by_default")
@@ -42,6 +42,23 @@ async def test_device_tracker_alt(
     assert_entities_alt(hass, entry.entry_id, entity_registry, snapshot)
 
 
+@pytest.mark.usefixtures("entity_registry_enabled_by_default")
+async def test_device_tracker_noscope(
+    hass: HomeAssistant,
+    snapshot: SnapshotAssertion,
+    entity_registry: er.EntityRegistry,
+    mock_metadata: AsyncMock,
+    mock_vehicle_data: AsyncMock,
+    mock_legacy: AsyncMock,
+) -> None:
+    """Tests that the device tracker entities are correct."""
+
+    mock_metadata.return_value = METADATA_NOSCOPE
+    entry = await setup_platform(hass, [Platform.DEVICE_TRACKER])
+    entity_entries = er.async_entries_for_config_entry(entity_registry, entry.entry_id)
+    assert len(entity_entries) == 0
+
+
 @pytest.mark.usefixtures("entity_registry_enabled_by_default")
 async def test_device_tracker_streaming(
     hass: HomeAssistant,