Rewrite fail2ban unittest tests to pytest style test functions (#41606)

This commit is contained in:
CurrentThread 2020-10-16 12:04:53 +02:00 committed by GitHub
parent 2146dd1268
commit a28f347b2b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1,18 +1,14 @@
"""The tests for local file sensor platform.""" """The tests for local file sensor platform."""
import unittest
from mock_open import MockOpen
from homeassistant.components.fail2ban.sensor import ( from homeassistant.components.fail2ban.sensor import (
STATE_ALL_BANS, STATE_ALL_BANS,
STATE_CURRENT_BANS, STATE_CURRENT_BANS,
BanLogParser, BanLogParser,
BanSensor, BanSensor,
) )
from homeassistant.setup import setup_component from homeassistant.setup import async_setup_component
from tests.async_mock import Mock, patch from tests.async_mock import Mock, mock_open, patch
from tests.common import assert_setup_component, get_test_home_assistant from tests.common import assert_setup_component
def fake_log(log_key): def fake_log(log_key):
@ -60,77 +56,63 @@ def fake_log(log_key):
return fake_log_dict[log_key] return fake_log_dict[log_key]
class TestBanSensor(unittest.TestCase): @patch("os.path.isfile", Mock(return_value=True))
"""Test the fail2ban sensor.""" async def test_setup(hass):
def setUp(self):
"""Set up things to be run when tests are started."""
self.hass = get_test_home_assistant()
self.addCleanup(self.hass.stop)
@patch("os.path.isfile", Mock(return_value=True))
def test_setup(self):
"""Test that sensor can be setup.""" """Test that sensor can be setup."""
config = {"sensor": {"platform": "fail2ban", "jails": ["jail_one"]}} config = {"sensor": {"platform": "fail2ban", "jails": ["jail_one"]}}
mock_fh = MockOpen() mock_fh = mock_open()
with patch( with patch("homeassistant.components.fail2ban.sensor.open", mock_fh, create=True):
"homeassistant.components.fail2ban.sensor.open", mock_fh, create=True assert await async_setup_component(hass, "sensor", config)
): await hass.async_block_till_done()
assert setup_component(self.hass, "sensor", config)
self.hass.block_till_done()
assert_setup_component(1, "sensor") assert_setup_component(1, "sensor")
@patch("os.path.isfile", Mock(return_value=True))
def test_multi_jails(self): @patch("os.path.isfile", Mock(return_value=True))
async def test_multi_jails(hass):
"""Test that multiple jails can be set up as sensors..""" """Test that multiple jails can be set up as sensors.."""
config = {"sensor": {"platform": "fail2ban", "jails": ["jail_one", "jail_two"]}} config = {"sensor": {"platform": "fail2ban", "jails": ["jail_one", "jail_two"]}}
mock_fh = MockOpen() mock_fh = mock_open()
with patch( with patch("homeassistant.components.fail2ban.sensor.open", mock_fh, create=True):
"homeassistant.components.fail2ban.sensor.open", mock_fh, create=True assert await async_setup_component(hass, "sensor", config)
): await hass.async_block_till_done()
assert setup_component(self.hass, "sensor", config)
self.hass.block_till_done()
assert_setup_component(2, "sensor") assert_setup_component(2, "sensor")
def test_single_ban(self):
async def test_single_ban(hass):
"""Test that log is parsed correctly for single ban.""" """Test that log is parsed correctly for single ban."""
log_parser = BanLogParser("/test/fail2ban.log") log_parser = BanLogParser("/test/fail2ban.log")
sensor = BanSensor("fail2ban", "jail_one", log_parser) sensor = BanSensor("fail2ban", "jail_one", log_parser)
assert sensor.name == "fail2ban jail_one" assert sensor.name == "fail2ban jail_one"
mock_fh = MockOpen(read_data=fake_log("single_ban")) mock_fh = mock_open(read_data=fake_log("single_ban"))
with patch( with patch("homeassistant.components.fail2ban.sensor.open", mock_fh, create=True):
"homeassistant.components.fail2ban.sensor.open", mock_fh, create=True
):
sensor.update() sensor.update()
assert sensor.state == "111.111.111.111" assert sensor.state == "111.111.111.111"
assert sensor.state_attributes[STATE_CURRENT_BANS] == ["111.111.111.111"] assert sensor.state_attributes[STATE_CURRENT_BANS] == ["111.111.111.111"]
assert sensor.state_attributes[STATE_ALL_BANS] == ["111.111.111.111"] assert sensor.state_attributes[STATE_ALL_BANS] == ["111.111.111.111"]
def test_ipv6_ban(self):
async def test_ipv6_ban(hass):
"""Test that log is parsed correctly for IPV6 bans.""" """Test that log is parsed correctly for IPV6 bans."""
log_parser = BanLogParser("/test/fail2ban.log") log_parser = BanLogParser("/test/fail2ban.log")
sensor = BanSensor("fail2ban", "jail_one", log_parser) sensor = BanSensor("fail2ban", "jail_one", log_parser)
assert sensor.name == "fail2ban jail_one" assert sensor.name == "fail2ban jail_one"
mock_fh = MockOpen(read_data=fake_log("ipv6_ban")) mock_fh = mock_open(read_data=fake_log("ipv6_ban"))
with patch( with patch("homeassistant.components.fail2ban.sensor.open", mock_fh, create=True):
"homeassistant.components.fail2ban.sensor.open", mock_fh, create=True
):
sensor.update() sensor.update()
assert sensor.state == "2607:f0d0:1002:51::4" assert sensor.state == "2607:f0d0:1002:51::4"
assert sensor.state_attributes[STATE_CURRENT_BANS] == ["2607:f0d0:1002:51::4"] assert sensor.state_attributes[STATE_CURRENT_BANS] == ["2607:f0d0:1002:51::4"]
assert sensor.state_attributes[STATE_ALL_BANS] == ["2607:f0d0:1002:51::4"] assert sensor.state_attributes[STATE_ALL_BANS] == ["2607:f0d0:1002:51::4"]
def test_multiple_ban(self):
async def test_multiple_ban(hass):
"""Test that log is parsed correctly for multiple ban.""" """Test that log is parsed correctly for multiple ban."""
log_parser = BanLogParser("/test/fail2ban.log") log_parser = BanLogParser("/test/fail2ban.log")
sensor = BanSensor("fail2ban", "jail_one", log_parser) sensor = BanSensor("fail2ban", "jail_one", log_parser)
assert sensor.name == "fail2ban jail_one" assert sensor.name == "fail2ban jail_one"
mock_fh = MockOpen(read_data=fake_log("multi_ban")) mock_fh = mock_open(read_data=fake_log("multi_ban"))
with patch( with patch("homeassistant.components.fail2ban.sensor.open", mock_fh, create=True):
"homeassistant.components.fail2ban.sensor.open", mock_fh, create=True
):
sensor.update() sensor.update()
assert sensor.state == "222.222.222.222" assert sensor.state == "222.222.222.222"
@ -143,15 +125,14 @@ class TestBanSensor(unittest.TestCase):
"222.222.222.222", "222.222.222.222",
] ]
def test_unban_all(self):
async def test_unban_all(hass):
"""Test that log is parsed correctly when unbanning.""" """Test that log is parsed correctly when unbanning."""
log_parser = BanLogParser("/test/fail2ban.log") log_parser = BanLogParser("/test/fail2ban.log")
sensor = BanSensor("fail2ban", "jail_one", log_parser) sensor = BanSensor("fail2ban", "jail_one", log_parser)
assert sensor.name == "fail2ban jail_one" assert sensor.name == "fail2ban jail_one"
mock_fh = MockOpen(read_data=fake_log("unban_all")) mock_fh = mock_open(read_data=fake_log("unban_all"))
with patch( with patch("homeassistant.components.fail2ban.sensor.open", mock_fh, create=True):
"homeassistant.components.fail2ban.sensor.open", mock_fh, create=True
):
sensor.update() sensor.update()
assert sensor.state == "None" assert sensor.state == "None"
@ -161,15 +142,14 @@ class TestBanSensor(unittest.TestCase):
"222.222.222.222", "222.222.222.222",
] ]
def test_unban_one(self):
async def test_unban_one(hass):
"""Test that log is parsed correctly when unbanning one ip.""" """Test that log is parsed correctly when unbanning one ip."""
log_parser = BanLogParser("/test/fail2ban.log") log_parser = BanLogParser("/test/fail2ban.log")
sensor = BanSensor("fail2ban", "jail_one", log_parser) sensor = BanSensor("fail2ban", "jail_one", log_parser)
assert sensor.name == "fail2ban jail_one" assert sensor.name == "fail2ban jail_one"
mock_fh = MockOpen(read_data=fake_log("unban_one")) mock_fh = mock_open(read_data=fake_log("unban_one"))
with patch( with patch("homeassistant.components.fail2ban.sensor.open", mock_fh, create=True):
"homeassistant.components.fail2ban.sensor.open", mock_fh, create=True
):
sensor.update() sensor.update()
assert sensor.state == "222.222.222.222" assert sensor.state == "222.222.222.222"
@ -179,17 +159,16 @@ class TestBanSensor(unittest.TestCase):
"222.222.222.222", "222.222.222.222",
] ]
def test_multi_jail(self):
async def test_multi_jail(hass):
"""Test that log is parsed correctly when using multiple jails.""" """Test that log is parsed correctly when using multiple jails."""
log_parser = BanLogParser("/test/fail2ban.log") log_parser = BanLogParser("/test/fail2ban.log")
sensor1 = BanSensor("fail2ban", "jail_one", log_parser) sensor1 = BanSensor("fail2ban", "jail_one", log_parser)
sensor2 = BanSensor("fail2ban", "jail_two", log_parser) sensor2 = BanSensor("fail2ban", "jail_two", log_parser)
assert sensor1.name == "fail2ban jail_one" assert sensor1.name == "fail2ban jail_one"
assert sensor2.name == "fail2ban jail_two" assert sensor2.name == "fail2ban jail_two"
mock_fh = MockOpen(read_data=fake_log("multi_jail")) mock_fh = mock_open(read_data=fake_log("multi_jail"))
with patch( with patch("homeassistant.components.fail2ban.sensor.open", mock_fh, create=True):
"homeassistant.components.fail2ban.sensor.open", mock_fh, create=True
):
sensor1.update() sensor1.update()
sensor2.update() sensor2.update()
@ -200,15 +179,14 @@ class TestBanSensor(unittest.TestCase):
assert sensor2.state_attributes[STATE_CURRENT_BANS] == ["222.222.222.222"] assert sensor2.state_attributes[STATE_CURRENT_BANS] == ["222.222.222.222"]
assert sensor2.state_attributes[STATE_ALL_BANS] == ["222.222.222.222"] assert sensor2.state_attributes[STATE_ALL_BANS] == ["222.222.222.222"]
def test_ban_active_after_update(self):
async def test_ban_active_after_update(hass):
"""Test that ban persists after subsequent update.""" """Test that ban persists after subsequent update."""
log_parser = BanLogParser("/test/fail2ban.log") log_parser = BanLogParser("/test/fail2ban.log")
sensor = BanSensor("fail2ban", "jail_one", log_parser) sensor = BanSensor("fail2ban", "jail_one", log_parser)
assert sensor.name == "fail2ban jail_one" assert sensor.name == "fail2ban jail_one"
mock_fh = MockOpen(read_data=fake_log("single_ban")) mock_fh = mock_open(read_data=fake_log("single_ban"))
with patch( with patch("homeassistant.components.fail2ban.sensor.open", mock_fh, create=True):
"homeassistant.components.fail2ban.sensor.open", mock_fh, create=True
):
sensor.update() sensor.update()
assert sensor.state == "111.111.111.111" assert sensor.state == "111.111.111.111"
sensor.update() sensor.update()