jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-23 21:27:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Support correcting sensor volume unit (#80081)

Browse Source
This commit is contained in:
Erik Montnemery 2022-10-11 13:51:28 +02:00 committed by GitHub
parent c52b900bfe
commit a391b8dd9d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
homeassistant/components/sensor/recorder.py
View File

@ -23,7 +23,12 @@ from homeassistant.components.recorder.models import (
StatisticMetaData, StatisticMetaData,
StatisticResult, StatisticResult,
) )
from homeassistant.const import ATTR_UNIT_OF_MEASUREMENT, REVOLUTIONS_PER_MINUTE from homeassistant.const import (
ATTR_UNIT_OF_MEASUREMENT,
REVOLUTIONS_PER_MINUTE,
VOLUME_CUBIC_FEET,
VOLUME_CUBIC_METERS,
)
from homeassistant.core import HomeAssistant, State, split_entity_id from homeassistant.core import HomeAssistant, State, split_entity_id
from homeassistant.exceptions import HomeAssistantError from homeassistant.exceptions import HomeAssistantError
from homeassistant.helpers.entity import entity_sources from homeassistant.helpers.entity import entity_sources
@ -49,6 +54,8 @@ DEFAULT_STATISTICS = {
EQUIVALENT_UNITS = { EQUIVALENT_UNITS = {
"RPM": REVOLUTIONS_PER_MINUTE, "RPM": REVOLUTIONS_PER_MINUTE,
"ft3": VOLUME_CUBIC_FEET,
"m3": VOLUME_CUBIC_METERS,
} }
# Keep track of entities for which a warning about decreasing value has been logged # Keep track of entities for which a warning about decreasing value has been logged

16
tests/components/sensor/test_recorder.py
View File

@ -1912,6 +1912,9 @@ def test_list_statistic_ids_unsupported(hass_recorder, caplog, _attributes):
("battery", "%", "cats", None, 13.050847, -10, 30), ("battery", "%", "cats", None, 13.050847, -10, 30),
("battery", None, "cats", None, 13.050847, -10, 30), ("battery", None, "cats", None, 13.050847, -10, 30),
(None, "kW", "Wh", "power", 13.050847, -10, 30), (None, "kW", "Wh", "power", 13.050847, -10, 30),
# Can't downgrade from ft³ to ft3 or from m³ to m3
(None, "ft³", "ft3", "volume", 13.050847, -10, 30),
(None, "m³", "m3", "volume", 13.050847, -10, 30),
], ],
) )
def test_compile_hourly_statistics_changing_units_1( def test_compile_hourly_statistics_changing_units_1(
@ -2193,10 +2196,12 @@ def test_compile_hourly_statistics_changing_units_3(
@pytest.mark.parametrize( @pytest.mark.parametrize(
"device_class, state_unit, state_unit2, unit_class, mean, mean2, min, max", "device_class, state_unit, state_unit2, unit_class, unit_class2, mean, mean2, min, max",
[ [
(None, "RPM", "rpm", None, 13.050847, 13.333333, -10, 30), (None, "RPM", "rpm", None, None, 13.050847, 13.333333, -10, 30),
(None, "rpm", "RPM", None, 13.050847, 13.333333, -10, 30), (None, "rpm", "RPM", None, None, 13.050847, 13.333333, -10, 30),
(None, "ft3", "ft³", None, "volume", 13.050847, 13.333333, -10, 30),
(None, "m3", "m³", None, "volume", 13.050847, 13.333333, -10, 30),
], ],
) )
def test_compile_hourly_statistics_equivalent_units_1( def test_compile_hourly_statistics_equivalent_units_1(
@ -2206,6 +2211,7 @@ def test_compile_hourly_statistics_equivalent_units_1(
state_unit, state_unit,
state_unit2, state_unit2,
unit_class, unit_class,
unit_class2,
mean, mean,
mean2, mean2,
min, min,
@ -2277,7 +2283,7 @@ def test_compile_hourly_statistics_equivalent_units_1(
"name": None, "name": None,
"source": "recorder", "source": "recorder",
"statistics_unit_of_measurement": state_unit2, "statistics_unit_of_measurement": state_unit2,
"unit_class": unit_class, "unit_class": unit_class2,
}, },
] ]
stats = statistics_during_period(hass, zero, period="5minute") stats = statistics_during_period(hass, zero, period="5minute")
@ -2317,6 +2323,8 @@ def test_compile_hourly_statistics_equivalent_units_1(
[ [
(None, "RPM", "rpm", None, 13.333333, -10, 30), (None, "RPM", "rpm", None, 13.333333, -10, 30),
(None, "rpm", "RPM", None, 13.333333, -10, 30), (None, "rpm", "RPM", None, 13.333333, -10, 30),
(None, "ft3", "ft³", None, 13.333333, -10, 30),
(None, "m3", "m³", None, 13.333333, -10, 30),
], ],
) )
def test_compile_hourly_statistics_equivalent_units_2( def test_compile_hourly_statistics_equivalent_units_2(