jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-19 19:27:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use super constructor self.config_entry in enphase_envoy coordinator (#133718)

Browse Source
This commit is contained in:
Arie Catsman 2024-12-21 13:19:04 +01:00 committed by GitHub
parent a3fab094c3
commit a3fad89d0d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
homeassistant/components/enphase_envoy/coordinator.py
View File

@ -37,6 +37,7 @@ class EnphaseUpdateCoordinator(DataUpdateCoordinator[dict[str, Any]]):
envoy_serial_number: str envoy_serial_number: str
envoy_firmware: str envoy_firmware: str
config_entry: EnphaseConfigEntry
def __init__( def __init__(
self, hass: HomeAssistant, envoy: Envoy, entry: EnphaseConfigEntry self, hass: HomeAssistant, envoy: Envoy, entry: EnphaseConfigEntry
@ -44,7 +45,6 @@ class EnphaseUpdateCoordinator(DataUpdateCoordinator[dict[str, Any]]):
"""Initialize DataUpdateCoordinator for the envoy.""" """Initialize DataUpdateCoordinator for the envoy."""
self.envoy = envoy self.envoy = envoy
entry_data = entry.data entry_data = entry.data
self.entry = entry
self.username = entry_data[CONF_USERNAME] self.username = entry_data[CONF_USERNAME]
self.password = entry_data[CONF_PASSWORD] self.password = entry_data[CONF_PASSWORD]
self._setup_complete = False self._setup_complete = False
@ -107,7 +107,7 @@ class EnphaseUpdateCoordinator(DataUpdateCoordinator[dict[str, Any]]):
await envoy.setup() await envoy.setup()
assert envoy.serial_number is not None assert envoy.serial_number is not None
self.envoy_serial_number = envoy.serial_number self.envoy_serial_number = envoy.serial_number
if token := self.entry.data.get(CONF_TOKEN): if token := self.config_entry.data.get(CONF_TOKEN):
with contextlib.suppress(*INVALID_AUTH_ERRORS): with contextlib.suppress(*INVALID_AUTH_ERRORS):
# Always set the username and password # Always set the username and password
# so we can refresh the token if needed # so we can refresh the token if needed
@ -136,9 +136,9 @@ class EnphaseUpdateCoordinator(DataUpdateCoordinator[dict[str, Any]]):
# as long as the token is valid # as long as the token is valid
_LOGGER.debug("%s: Updating token in config entry from auth", self.name) _LOGGER.debug("%s: Updating token in config entry from auth", self.name)
self.hass.config_entries.async_update_entry( self.hass.config_entries.async_update_entry(
self.entry, self.config_entry,
data={ data={
**self.entry.data, **self.config_entry.data,
CONF_TOKEN: envoy.auth.token, CONF_TOKEN: envoy.auth.token,
}, },
) )
@ -189,7 +189,7 @@ class EnphaseUpdateCoordinator(DataUpdateCoordinator[dict[str, Any]]):
) )
# reload the integration to get all established again # reload the integration to get all established again
self.hass.async_create_task( self.hass.async_create_task(
self.hass.config_entries.async_reload(self.entry.entry_id) self.hass.config_entries.async_reload(self.config_entry.entry_id)
) )
# remember firmware version for next time # remember firmware version for next time
self.envoy_firmware = envoy.firmware self.envoy_firmware = envoy.firmware

7
homeassistant/components/enphase_envoy/quality_scale.yaml
View File

@ -7,12 +7,7 @@ rules:
status: done status: done
comment: fixed 1 minute cycle based on Enphase Envoy device characteristics comment: fixed 1 minute cycle based on Enphase Envoy device characteristics
brands: done brands: done
common-modules: common-modules: done
status: done
comment: |
In coordinator.py, you set self.entry = entry, while after the super constructor,
you can access the entry via self.config_entry (you would have to overwrite the
type to make sure you don't have to assert not None every time)done
config-flow-test-coverage: config-flow-test-coverage:
status: todo status: todo
comment: | comment: |