jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-16 17:57:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow non-authenticated calls to snapshots during onboarding (#40582)

Browse Source
This commit is contained in:
Joakim Sørensen 2020-09-26 09:26:02 +02:00 committed by GitHub
parent 4a63b83caa
commit a42736e437
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
homeassistant/components/hassio/http.py
View File

@ -12,6 +12,7 @@ from aiohttp.web_exceptions import HTTPBadGateway
import async_timeout import async_timeout
from homeassistant.components.http import KEY_AUTHENTICATED, HomeAssistantView from homeassistant.components.http import KEY_AUTHENTICATED, HomeAssistantView
from homeassistant.components.onboarding import async_is_onboarded
from homeassistant.const import HTTP_UNAUTHORIZED from homeassistant.const import HTTP_UNAUTHORIZED
from .const import X_HASS_IS_ADMIN, X_HASS_USER_ID, X_HASSIO from .const import X_HASS_IS_ADMIN, X_HASS_USER_ID, X_HASSIO
@ -54,7 +55,8 @@ class HassIOView(HomeAssistantView):
self, request: web.Request, path: str self, request: web.Request, path: str
) -> Union[web.Response, web.StreamResponse]: ) -> Union[web.Response, web.StreamResponse]:
"""Route data to Hass.io.""" """Route data to Hass.io."""
if _need_auth(path) and not request[KEY_AUTHENTICATED]: hass = request.app["hass"]
if _need_auth(hass, path) and not request[KEY_AUTHENTICATED]:
return web.Response(status=HTTP_UNAUTHORIZED) return web.Response(status=HTTP_UNAUTHORIZED)
return await self._command_proxy(path, request) return await self._command_proxy(path, request)
@ -145,8 +147,10 @@ def _get_timeout(path: str) -> int:
return 300 return 300
def _need_auth(path: str) -> bool: def _need_auth(hass, path: str) -> bool:
"""Return if a path need authentication.""" """Return if a path need authentication."""
if not async_is_onboarded(hass) and path.startswith("snapshots"):
return False
if NO_AUTH.match(path): if NO_AUTH.match(path):
return False return False
return True return True

11
tests/components/hassio/test_http.py
View File

@ -3,6 +3,8 @@ import asyncio
import pytest import pytest
from homeassistant.components.hassio.http import _need_auth
from tests.async_mock import patch from tests.async_mock import patch
@ -147,3 +149,12 @@ async def test_snapshot_upload_headers(hassio_client, aioclient_mock):
req_headers = aioclient_mock.mock_calls[0][-1] req_headers = aioclient_mock.mock_calls[0][-1]
req_headers["Content-Type"] == content_type req_headers["Content-Type"] == content_type
def test_need_auth(hass):
"""Test if the requested path needs authentication."""
assert not _need_auth(hass, "addons/test/logo")
assert _need_auth(hass, "snapshots/new/upload")
hass.data["onboarding"] = False
assert not _need_auth(hass, "snapshots/new/upload")