From a65edc8dc146a8424bfd2a11f59090538cdd265a Mon Sep 17 00:00:00 2001 From: Frederik Gladhorn Date: Thu, 30 Apr 2020 14:52:53 +0200 Subject: [PATCH] Fix crash in NAD integration (#34571) Some amplifiers/receivers do not report any volume (due to them not knowing), for example NAD C 356BEE is documented to return an empty string for volume. At least don't crash when we get None back. --- homeassistant/components/nad/media_player.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/homeassistant/components/nad/media_player.py b/homeassistant/components/nad/media_player.py index c9015b85fd1..2d9afbb7541 100644 --- a/homeassistant/components/nad/media_player.py +++ b/homeassistant/components/nad/media_player.py @@ -197,7 +197,10 @@ class NAD(MediaPlayerEntity): else: self._mute = True - self._volume = self.calc_volume(self._nad_receiver.main_volume("?")) + volume = self._nad_receiver.main_volume("?") + # Some receivers cannot report the volume, e.g. C 356BEE, + # instead they only support stepping the volume up or down + self._volume = self.calc_volume(volume) if volume is not None else None self._source = self._source_dict.get(self._nad_receiver.main_source("?")) def calc_volume(self, decibel):