jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-25 06:07:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Log not allowed attributes only once in BMW binary sensors (#76708)

Browse Source 
* Log not allowed keys only once

* Fix spelling

Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com>

Co-authored-by: rikroe <rikroe@users.noreply.github.com>
Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com>
This commit is contained in:
rikroe 2022-08-13 16:05:23 +02:00 committed by GitHub
parent db03c273f1
commit a70252a243
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
homeassistant/components/bmw_connected_drive/binary_sensor.py
View File

@ -37,8 +37,10 @@ ALLOWED_CONDITION_BASED_SERVICE_KEYS = {
"VEHICLE_CHECK", "VEHICLE_CHECK",
"VEHICLE_TUV", "VEHICLE_TUV",
} }
LOGGED_CONDITION_BASED_SERVICE_WARNINGS = set()
ALLOWED_CHECK_CONTROL_MESSAGE_KEYS = {"ENGINE_OIL", "TIRE_PRESSURE"} ALLOWED_CHECK_CONTROL_MESSAGE_KEYS = {"ENGINE_OIL", "TIRE_PRESSURE"}
LOGGED_CHECK_CONTROL_MESSAGE_WARNINGS = set()
def _condition_based_services( def _condition_based_services(
@ -46,12 +48,16 @@ def _condition_based_services(
) -> dict[str, Any]: ) -> dict[str, Any]:
extra_attributes = {} extra_attributes = {}
for report in vehicle.condition_based_services.messages: for report in vehicle.condition_based_services.messages:
if report.service_type not in ALLOWED_CONDITION_BASED_SERVICE_KEYS: if (
report.service_type not in ALLOWED_CONDITION_BASED_SERVICE_KEYS
and report.service_type not in LOGGED_CONDITION_BASED_SERVICE_WARNINGS
):
_LOGGER.warning( _LOGGER.warning(
"'%s' not an allowed condition based service (%s)", "'%s' not an allowed condition based service (%s)",
report.service_type, report.service_type,
report, report,
) )
LOGGED_CONDITION_BASED_SERVICE_WARNINGS.add(report.service_type)
continue continue
extra_attributes.update(_format_cbs_report(report, unit_system)) extra_attributes.update(_format_cbs_report(report, unit_system))
@ -61,17 +67,19 @@ def _condition_based_services(
def _check_control_messages(vehicle: MyBMWVehicle) -> dict[str, Any]: def _check_control_messages(vehicle: MyBMWVehicle) -> dict[str, Any]:
extra_attributes: dict[str, Any] = {} extra_attributes: dict[str, Any] = {}
for message in vehicle.check_control_messages.messages: for message in vehicle.check_control_messages.messages:
if message.description_short not in ALLOWED_CHECK_CONTROL_MESSAGE_KEYS: if (
message.description_short not in ALLOWED_CHECK_CONTROL_MESSAGE_KEYS
and message.description_short not in LOGGED_CHECK_CONTROL_MESSAGE_WARNINGS
):
_LOGGER.warning( _LOGGER.warning(
"'%s' not an allowed check control message (%s)", "'%s' not an allowed check control message (%s)",
message.description_short, message.description_short,
message, message,
) )
LOGGED_CHECK_CONTROL_MESSAGE_WARNINGS.add(message.description_short)
continue continue
extra_attributes.update( extra_attributes[message.description_short.lower()] = message.state.value
{message.description_short.lower(): message.state.value}
)
return extra_attributes return extra_attributes