jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-06-25 07:27:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix unknown alarm websocket event error for restored SimpliSafe connections (#65457)

Browse Source
This commit is contained in:
Aaron Bach 2022-02-02 18:06:24 -07:00 committed by Paulus Schoutsen
parent f7ec373aab
commit a8b29c4be9
1 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
homeassistant/components/simplisafe/__init__.py
View File

@ -820,17 +820,6 @@ class SimpliSafeEntity(CoordinatorEntity):
): ):
return return
if event.event_type in (EVENT_CONNECTION_LOST, EVENT_POWER_OUTAGE):
self._online = False
elif event.event_type in (EVENT_CONNECTION_RESTORED, EVENT_POWER_RESTORED):
self._online = True
# It's uncertain whether SimpliSafe events will still propagate down the
# websocket when the base station is offline. Just in case, we guard against
# further action until connection is restored:
if not self._online:
return
sensor_type: str | None sensor_type: str | None
if event.sensor_type: if event.sensor_type:
sensor_type = event.sensor_type.name sensor_type = event.sensor_type.name
@ -846,6 +835,19 @@ class SimpliSafeEntity(CoordinatorEntity):
} }
) )
# It's unknown whether these events reach the base station (since the connection
# is lost); we include this for completeness and coverage:
if event.event_type in (EVENT_CONNECTION_LOST, EVENT_POWER_OUTAGE):
self._online = False
return
# If the base station comes back online, set entities to available, but don't
# instruct the entities to update their state (since there won't be anything new
# until the next websocket event or REST API update:
if event.event_type in (EVENT_CONNECTION_RESTORED, EVENT_POWER_RESTORED):
self._online = True
return
self.async_update_from_websocket_event(event) self.async_update_from_websocket_event(event)
self.async_write_ha_state() self.async_write_ha_state()