From a9baa24fda1ee3689acfa757d7e3b9ef1cc17968 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ville=20Skytt=C3=A4?= Date: Mon, 2 Dec 2019 03:58:31 +0800 Subject: [PATCH] Improve naming and attrs of hostnameless Huawei LTE device tracker entities (#29281) --- homeassistant/components/huawei_lte/device_tracker.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/homeassistant/components/huawei_lte/device_tracker.py b/homeassistant/components/huawei_lte/device_tracker.py index d95d99e7126..29d7f437b5f 100644 --- a/homeassistant/components/huawei_lte/device_tracker.py +++ b/homeassistant/components/huawei_lte/device_tracker.py @@ -145,11 +145,10 @@ class HuaweiLteScannerEntity(HuaweiLteBaseEntity, ScannerEntity): host = next((x for x in hosts if x.get("MacAddress") == self.mac), None) self._is_connected = host is not None if self._is_connected: - self._name = host.get("HostName", self.mac) + # HostName may be present with explicit None value + self._name = host.get("HostName") or self.mac self._device_state_attributes = { - _better_snakecase(k): v - for k, v in host.items() - if k not in ("MacAddress", "HostName") + _better_snakecase(k): v for k, v in host.items() if k != "HostName" }