From aca0fd317840df4f9b76c820c1757130b4872cf1 Mon Sep 17 00:00:00 2001 From: epenet <6771947+epenet@users.noreply.github.com> Date: Wed, 29 Jun 2022 09:46:05 +0200 Subject: [PATCH] Adjust type hints in rflink cover (#73946) * Adjust type hints in rflink cover * Move definition back to init * Use attributes * Revert "Use attributes" This reverts commit ff4851015d5e15b1b1304554228ca274d586977d. * Use _attr_should_poll --- homeassistant/components/rflink/__init__.py | 10 ++++------ homeassistant/components/rflink/cover.py | 11 +++-------- 2 files changed, 7 insertions(+), 14 deletions(-) diff --git a/homeassistant/components/rflink/__init__.py b/homeassistant/components/rflink/__init__.py index 563ecedec3d..7bc87de9f46 100644 --- a/homeassistant/components/rflink/__init__.py +++ b/homeassistant/components/rflink/__init__.py @@ -1,4 +1,6 @@ """Support for Rflink devices.""" +from __future__ import annotations + import asyncio from collections import defaultdict import logging @@ -315,8 +317,9 @@ class RflinkDevice(Entity): """ platform = None - _state = None + _state: bool | None = None _available = True + _attr_should_poll = False def __init__( self, @@ -369,11 +372,6 @@ class RflinkDevice(Entity): """Platform specific event handler.""" raise NotImplementedError() - @property - def should_poll(self): - """No polling needed.""" - return False - @property def name(self): """Return a name for the device.""" diff --git a/homeassistant/components/rflink/cover.py b/homeassistant/components/rflink/cover.py index 91e68fa0fb8..9492611f439 100644 --- a/homeassistant/components/rflink/cover.py +++ b/homeassistant/components/rflink/cover.py @@ -125,7 +125,7 @@ async def async_setup_platform( class RflinkCover(RflinkCommand, CoverEntity, RestoreEntity): """Rflink entity which can switch on/stop/off (eg: cover).""" - async def async_added_to_hass(self): + async def async_added_to_hass(self) -> None: """Restore RFLink cover state (OPEN/CLOSE).""" await super().async_added_to_hass() if (old_state := await self.async_get_last_state()) is not None: @@ -142,17 +142,12 @@ class RflinkCover(RflinkCommand, CoverEntity, RestoreEntity): self._state = False @property - def should_poll(self): - """No polling available in RFlink cover.""" - return False - - @property - def is_closed(self): + def is_closed(self) -> bool | None: """Return if the cover is closed.""" return not self._state @property - def assumed_state(self): + def assumed_state(self) -> bool: """Return True because covers can be stopped midway.""" return True