From acfc4711cde434aef6e0a659bdb522e7e8f603b4 Mon Sep 17 00:00:00 2001
From: Pete Sage <76050312+PeteRager@users.noreply.github.com>
Date: Sat, 16 Nov 2024 11:40:49 -0500
Subject: [PATCH] Fix Sonos get_queue action may fail if track metadata is
 missing (#130756)

initial commit
---
 homeassistant/components/sonos/media_player.py       |  6 +++---
 tests/components/sonos/fixtures/sonos_queue.json     | 12 ++++++++++++
 .../sonos/snapshots/test_media_player.ambr           |  6 ++++++
 3 files changed, 21 insertions(+), 3 deletions(-)

diff --git a/homeassistant/components/sonos/media_player.py b/homeassistant/components/sonos/media_player.py
index 7711a1e88ea..8d0917c5dba 100644
--- a/homeassistant/components/sonos/media_player.py
+++ b/homeassistant/components/sonos/media_player.py
@@ -782,9 +782,9 @@ class SonosMediaPlayerEntity(SonosEntity, MediaPlayerEntity):
         queue: list[DidlMusicTrack] = self.coordinator.soco.get_queue(max_items=0)
         return [
             {
-                ATTR_MEDIA_TITLE: track.title,
-                ATTR_MEDIA_ALBUM_NAME: track.album,
-                ATTR_MEDIA_ARTIST: track.creator,
+                ATTR_MEDIA_TITLE: getattr(track, "title", None),
+                ATTR_MEDIA_ALBUM_NAME: getattr(track, "album", None),
+                ATTR_MEDIA_ARTIST: getattr(track, "creator", None),
                 ATTR_MEDIA_CONTENT_ID: track.get_uri(),
             }
             for track in queue
diff --git a/tests/components/sonos/fixtures/sonos_queue.json b/tests/components/sonos/fixtures/sonos_queue.json
index 50689a00e1d..ffe08fc2b08 100644
--- a/tests/components/sonos/fixtures/sonos_queue.json
+++ b/tests/components/sonos/fixtures/sonos_queue.json
@@ -26,5 +26,17 @@
         "protocol_info": "file:*:audio/mpegurl:*"
       }
     ]
+  },
+  {
+    "title": "Track with no album or creator",
+    "item_id": "Q:0/3",
+    "parent_id": "Q:0",
+    "original_track_number": 1,
+    "resources": [
+      {
+        "uri": "x-file-cifs://192.168.42.10/music/TrackWithNoAlbumOrCreator.mp3",
+        "protocol_info": "file:*:audio/mpegurl:*"
+      }
+    ]
   }
 ]
diff --git a/tests/components/sonos/snapshots/test_media_player.ambr b/tests/components/sonos/snapshots/test_media_player.ambr
index f382d341de6..8ef298de3db 100644
--- a/tests/components/sonos/snapshots/test_media_player.ambr
+++ b/tests/components/sonos/snapshots/test_media_player.ambr
@@ -71,6 +71,12 @@
         'media_content_id': 'x-file-cifs://192.168.42.10/music/The%20Beatles/Abbey%20Road/01%20Come%20Together.mp3',
         'media_title': 'Come Together',
       }),
+      dict({
+        'media_album_name': None,
+        'media_artist': None,
+        'media_content_id': 'x-file-cifs://192.168.42.10/music/TrackWithNoAlbumOrCreator.mp3',
+        'media_title': 'Track with no album or creator',
+      }),
     ]),
   })
 # ---