jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-19 19:27:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Sonos get_queue action may fail if track metadata is missing (#130756)

Browse Source 
initial commit
This commit is contained in:
Pete Sage 2024-11-16 11:40:49 -05:00 committed by GitHub
parent c219b512eb
commit acfc4711cd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 21 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
homeassistant/components/sonos/media_player.py
View File

@ -782,9 +782,9 @@ class SonosMediaPlayerEntity(SonosEntity, MediaPlayerEntity):
queue: list[DidlMusicTrack] = self.coordinator.soco.get_queue(max_items=0) queue: list[DidlMusicTrack] = self.coordinator.soco.get_queue(max_items=0)
return [ return [
{ {
ATTR_MEDIA_TITLE: track.title, ATTR_MEDIA_TITLE: getattr(track, "title", None),
ATTR_MEDIA_ALBUM_NAME: track.album, ATTR_MEDIA_ALBUM_NAME: getattr(track, "album", None),
ATTR_MEDIA_ARTIST: track.creator, ATTR_MEDIA_ARTIST: getattr(track, "creator", None),
ATTR_MEDIA_CONTENT_ID: track.get_uri(), ATTR_MEDIA_CONTENT_ID: track.get_uri(),
} }
for track in queue for track in queue

12
tests/components/sonos/fixtures/sonos_queue.json
View File

@ -26,5 +26,17 @@
"protocol_info": "file:*:audio/mpegurl:*" "protocol_info": "file:*:audio/mpegurl:*"
} }
] ]
},
{
"title": "Track with no album or creator",
"item_id": "Q:0/3",
"parent_id": "Q:0",
"original_track_number": 1,
"resources": [
{
"uri": "x-file-cifs://192.168.42.10/music/TrackWithNoAlbumOrCreator.mp3",
"protocol_info": "file:*:audio/mpegurl:*"
}
]
} }
] ]

6
tests/components/sonos/snapshots/test_media_player.ambr
View File

@ -71,6 +71,12 @@
'media_content_id': 'x-file-cifs://192.168.42.10/music/The%20Beatles/Abbey%20Road/01%20Come%20Together.mp3', 'media_content_id': 'x-file-cifs://192.168.42.10/music/The%20Beatles/Abbey%20Road/01%20Come%20Together.mp3',
'media_title': 'Come Together', 'media_title': 'Come Together',
}), }),
dict({
'media_album_name': None,
'media_artist': None,
'media_content_id': 'x-file-cifs://192.168.42.10/music/TrackWithNoAlbumOrCreator.mp3',
'media_title': 'Track with no album or creator',
}),
]), ]),
}) })
# --- # ---