From ad24cbddccfb960f448806b3a40b16b85c193f11 Mon Sep 17 00:00:00 2001 From: Paul Annekov Date: Fri, 2 Feb 2018 15:02:11 +0200 Subject: [PATCH] fixed wrong check for valid range of 'rgb' values (#12132) --- homeassistant/components/light/xiaomi_aqara.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/homeassistant/components/light/xiaomi_aqara.py b/homeassistant/components/light/xiaomi_aqara.py index d1664d13072..efe37d3d577 100644 --- a/homeassistant/components/light/xiaomi_aqara.py +++ b/homeassistant/components/light/xiaomi_aqara.py @@ -51,13 +51,13 @@ class XiaomiGatewayLight(XiaomiDevice, Light): return True rgbhexstr = "%x" % value - if len(rgbhexstr) == 7: - rgbhexstr = '0' + rgbhexstr - elif len(rgbhexstr) != 8: - _LOGGER.error('Light RGB data error.' - ' Must be 8 characters. Received: %s', rgbhexstr) + if len(rgbhexstr) > 8: + _LOGGER.error("Light RGB data error." + " Can't be more than 8 characters. Received: %s", + rgbhexstr) return False + rgbhexstr = rgbhexstr.zfill(8) rgbhex = bytes.fromhex(rgbhexstr) rgba = struct.unpack('BBBB', rgbhex) brightness = rgba[0]