Streamline SimpliSafe errors (#43117)

This commit is contained in:
Aaron Bach 2020-11-13 01:38:58 -07:00 committed by GitHub
parent 899fc3d35a
commit ad7f1446be
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -534,8 +534,7 @@ class SimpliSafe:
) )
) )
LOGGER.error("Update failed with stored refresh token") raise UpdateFailed("Update failed with stored refresh token")
raise UpdateFailed from result
LOGGER.warning("SimpliSafe cloud error; trying stored refresh token") LOGGER.warning("SimpliSafe cloud error; trying stored refresh token")
self._emergency_refresh_token_used = True self._emergency_refresh_token_used = True
@ -546,23 +545,18 @@ class SimpliSafe:
) )
return return
except SimplipyError as err: except SimplipyError as err:
LOGGER.error("Error while using stored refresh token: %s", err) raise UpdateFailed( # pylint: disable=raise-missing-from
raise UpdateFailed from err f"Error while using stored refresh token: {err}"
)
if isinstance(result, EndpointUnavailable): if isinstance(result, EndpointUnavailable):
# In case the user attempt an action not allowed in their current plan, # In case the user attempts an action not allowed in their current plan,
# we merely log that message at INFO level (so the user is aware, # we merely log that message at INFO level (so the user is aware,
# but not spammed with ERROR messages that they cannot change): # but not spammed with ERROR messages that they cannot change):
LOGGER.info(result) LOGGER.info(result)
raise UpdateFailed from result
if isinstance(result, SimplipyError): if isinstance(result, SimplipyError):
LOGGER.error("SimpliSafe error while updating: %s", result) raise UpdateFailed(f"SimpliSafe error while updating: {result}")
raise UpdateFailed from result
if isinstance(result, Exception):
LOGGER.error("Unknown error while updating: %s", result)
raise UpdateFailed from result
if self._api.refresh_token != self.config_entry.data[CONF_TOKEN]: if self._api.refresh_token != self.config_entry.data[CONF_TOKEN]:
_async_save_refresh_token( _async_save_refresh_token(