jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-13 16:27:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve error handling in Spotify (#129799)

Browse Source
This commit is contained in:
Joost Lekkerkerker 2024-11-04 12:34:00 +01:00 committed by GitHub
parent 08a53362a7
commit ae06f734ce
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
homeassistant/components/spotify/coordinator.py
View File

@ -75,7 +75,10 @@ class SpotifyCoordinator(DataUpdateCoordinator[SpotifyCoordinatorData]):
raise UpdateFailed("Error communicating with Spotify API") from err raise UpdateFailed("Error communicating with Spotify API") from err
async def _async_update_data(self) -> SpotifyCoordinatorData: async def _async_update_data(self) -> SpotifyCoordinatorData:
current = await self.client.get_playback() try:
current = await self.client.get_playback()
except SpotifyConnectionError as err:
raise UpdateFailed("Error communicating with Spotify API") from err
if not current: if not current:
return SpotifyCoordinatorData( return SpotifyCoordinatorData(
current_playback=None, current_playback=None,
@ -90,8 +93,17 @@ class SpotifyCoordinator(DataUpdateCoordinator[SpotifyCoordinatorData]):
audio_features: AudioFeatures | None = None audio_features: AudioFeatures | None = None
if (item := current.item) is not None and item.type == ItemType.TRACK: if (item := current.item) is not None and item.type == ItemType.TRACK:
if item.uri != self._currently_loaded_track: if item.uri != self._currently_loaded_track:
self._currently_loaded_track = item.uri try:
audio_features = await self.client.get_audio_features(item.uri) audio_features = await self.client.get_audio_features(item.uri)
except SpotifyConnectionError:
_LOGGER.debug(
"Unable to load audio features for track '%s'. "
"Continuing without audio features",
item.uri,
)
audio_features = None
else:
self._currently_loaded_track = item.uri
else: else:
audio_features = self.data.audio_features audio_features = self.data.audio_features
dj_playlist = False dj_playlist = False