jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-19 19:27:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve entry setup error logging for Plugwise (#65830)

Browse Source
This commit is contained in:
Franck Nijhof 2022-02-05 21:23:25 +01:00 committed by GitHub
parent 52d7ca6b1c
commit b299f80feb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
homeassistant/components/plugwise/gateway.py
View File

@ -39,7 +39,6 @@ _LOGGER = logging.getLogger(__name__)
async def async_setup_entry_gw(hass: HomeAssistant, entry: ConfigEntry) -> bool: async def async_setup_entry_gw(hass: HomeAssistant, entry: ConfigEntry) -> bool:
"""Set up Plugwise Smiles from a config entry.""" """Set up Plugwise Smiles from a config entry."""
websession = async_get_clientsession(hass, verify_ssl=False) websession = async_get_clientsession(hass, verify_ssl=False)
api = Smile( api = Smile(
host=entry.data[CONF_HOST], host=entry.data[CONF_HOST],
username=entry.data.get(CONF_USERNAME, DEFAULT_USERNAME), username=entry.data.get(CONF_USERNAME, DEFAULT_USERNAME),
@ -51,22 +50,20 @@ async def async_setup_entry_gw(hass: HomeAssistant, entry: ConfigEntry) -> bool:
try: try:
connected = await api.connect() connected = await api.connect()
if not connected:
_LOGGER.error("Unable to connect to Smile")
raise ConfigEntryNotReady
except InvalidAuthentication: except InvalidAuthentication:
_LOGGER.error("Invalid username or Smile ID") _LOGGER.error("Invalid username or Smile ID")
return False return False
except PlugwiseException as err: except PlugwiseException as err:
_LOGGER.error("Error while communicating to device %s", api.smile_name) raise ConfigEntryNotReady(
raise ConfigEntryNotReady from err f"Error while communicating to device {api.smile_name}"
) from err
except asyncio.TimeoutError as err: except asyncio.TimeoutError as err:
_LOGGER.error("Timeout while connecting to Smile %s", api.smile_name) raise ConfigEntryNotReady(
raise ConfigEntryNotReady from err f"Timeout while connecting to Smile {api.smile_name}"
) from err
if not connected:
raise ConfigEntryNotReady("Unable to connect to Smile")
async def async_update_data(): async def async_update_data():
"""Update data via API endpoint.""" """Update data via API endpoint."""
@ -84,7 +81,6 @@ async def async_setup_entry_gw(hass: HomeAssistant, entry: ConfigEntry) -> bool:
update_method=async_update_data, update_method=async_update_data,
update_interval=DEFAULT_SCAN_INTERVAL[api.smile_type], update_interval=DEFAULT_SCAN_INTERVAL[api.smile_type],
) )
await coordinator.async_config_entry_first_refresh() await coordinator.async_config_entry_first_refresh()
api.get_all_devices() api.get_all_devices()
@ -101,7 +97,7 @@ async def async_setup_entry_gw(hass: HomeAssistant, entry: ConfigEntry) -> bool:
device_registry = dr.async_get(hass) device_registry = dr.async_get(hass)
device_registry.async_get_or_create( device_registry.async_get_or_create(
config_entry_id=entry.entry_id, config_entry_id=entry.entry_id,
identifiers={(DOMAIN, api.gateway_id)}, identifiers={(DOMAIN, str(api.gateway_id))},
manufacturer="Plugwise", manufacturer="Plugwise",
name=entry.title, name=entry.title,
model=f"Smile {api.smile_name}", model=f"Smile {api.smile_name}",