diff --git a/homeassistant/components/glances/config_flow.py b/homeassistant/components/glances/config_flow.py index 568586f177b..a56fa795491 100644 --- a/homeassistant/components/glances/config_flow.py +++ b/homeassistant/components/glances/config_flow.py @@ -36,7 +36,7 @@ DATA_SCHEMA = vol.Schema( vol.Optional(CONF_USERNAME): str, vol.Optional(CONF_PASSWORD): str, vol.Required(CONF_PORT, default=DEFAULT_PORT): int, - vol.Required(CONF_VERSION, default=DEFAULT_VERSION): int, + vol.Required(CONF_VERSION, default=DEFAULT_VERSION): vol.In(SUPPORTED_VERSIONS), vol.Optional(CONF_SSL, default=False): bool, vol.Optional(CONF_VERIFY_SSL, default=False): bool, } @@ -45,8 +45,6 @@ DATA_SCHEMA = vol.Schema( async def validate_input(hass: core.HomeAssistant, data): """Validate the user input allows us to connect.""" - if data[CONF_VERSION] not in SUPPORTED_VERSIONS: - raise WrongVersion try: api = get_api(hass, data) await api.get_data("all") @@ -81,8 +79,6 @@ class GlancesFlowHandler(config_entries.ConfigFlow, domain=DOMAIN): ) except CannotConnect: errors["base"] = "cannot_connect" - except WrongVersion: - errors[CONF_VERSION] = "wrong_version" return self.async_show_form( step_id="user", data_schema=DATA_SCHEMA, errors=errors @@ -117,7 +113,3 @@ class GlancesOptionsFlowHandler(config_entries.OptionsFlow): class CannotConnect(exceptions.HomeAssistantError): """Error to indicate we cannot connect.""" - - -class WrongVersion(exceptions.HomeAssistantError): - """Error to indicate the selected version is wrong.""" diff --git a/tests/components/glances/test_config_flow.py b/tests/components/glances/test_config_flow.py index 7b2dee6429e..40e40b45e11 100644 --- a/tests/components/glances/test_config_flow.py +++ b/tests/components/glances/test_config_flow.py @@ -75,22 +75,6 @@ async def test_form_cannot_connect(hass: HomeAssistant) -> None: assert result["errors"] == {"base": "cannot_connect"} -async def test_form_wrong_version(hass: HomeAssistant) -> None: - """Test to check if wrong version is entered.""" - - user_input = DEMO_USER_INPUT.copy() - user_input.update(version=1) - result = await hass.config_entries.flow.async_init( - glances.DOMAIN, context={"source": config_entries.SOURCE_USER} - ) - result = await hass.config_entries.flow.async_configure( - result["flow_id"], user_input=user_input - ) - - assert result["type"] == "form" - assert result["errors"] == {"version": "wrong_version"} - - async def test_form_already_configured(hass: HomeAssistant) -> None: """Test host is already configured.""" entry = MockConfigEntry(