From b3e10198ddaac7c2cb1575f476705bc01340ef50 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= Date: Sun, 25 Feb 2024 22:23:18 +0100 Subject: [PATCH] Enable CONF_STATION_UPDATES by default on AEMET (#111214) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * aemet: set CONF_STATION_UPDATES default to True Signed-off-by: Álvaro Fernández Rojas * tests: aemet: check CONF_STATION_UPDATES default form value Signed-off-by: Álvaro Fernández Rojas * Revert "tests: aemet: check CONF_STATION_UPDATES default form value" This reverts commit f0f95da68fa5b2d8964b0a45cbd9939843deccfb. * tests: aemet: parametriz test_form_options Signed-off-by: Álvaro Fernández Rojas --------- Signed-off-by: Álvaro Fernández Rojas --- homeassistant/components/aemet/config_flow.py | 2 +- tests/components/aemet/test_config_flow.py | 27 +++++-------------- 2 files changed, 8 insertions(+), 21 deletions(-) diff --git a/homeassistant/components/aemet/config_flow.py b/homeassistant/components/aemet/config_flow.py index ac51c997907..bb73311aa55 100644 --- a/homeassistant/components/aemet/config_flow.py +++ b/homeassistant/components/aemet/config_flow.py @@ -21,7 +21,7 @@ from .const import CONF_STATION_UPDATES, DEFAULT_NAME, DOMAIN OPTIONS_SCHEMA = vol.Schema( { - vol.Required(CONF_STATION_UPDATES): bool, + vol.Required(CONF_STATION_UPDATES, default=True): bool, } ) OPTIONS_FLOW = { diff --git a/tests/components/aemet/test_config_flow.py b/tests/components/aemet/test_config_flow.py index 0caacf4e4c0..d4cedcaf3d0 100644 --- a/tests/components/aemet/test_config_flow.py +++ b/tests/components/aemet/test_config_flow.py @@ -59,9 +59,14 @@ async def test_form(hass: HomeAssistant, mock_setup_entry: AsyncMock) -> None: assert len(mock_setup_entry.mock_calls) == 1 +@pytest.mark.parametrize( + ("user_input", "expected"), [({}, True), ({CONF_STATION_UPDATES: False}, False)] +) async def test_form_options( hass: HomeAssistant, freezer: FrozenDateTimeFactory, + user_input: dict[str, bool], + expected: bool, ) -> None: """Test the form options.""" @@ -87,30 +92,12 @@ async def test_form_options( assert result["step_id"] == "init" result = await hass.config_entries.options.async_configure( - result["flow_id"], user_input={CONF_STATION_UPDATES: False} + result["flow_id"], user_input=user_input ) assert result["type"] == data_entry_flow.FlowResultType.CREATE_ENTRY assert entry.options == { - CONF_STATION_UPDATES: False, - } - - await hass.async_block_till_done() - - assert entry.state is ConfigEntryState.LOADED - - result = await hass.config_entries.options.async_init(entry.entry_id) - - assert result["type"] == data_entry_flow.FlowResultType.FORM - assert result["step_id"] == "init" - - result = await hass.config_entries.options.async_configure( - result["flow_id"], user_input={CONF_STATION_UPDATES: True} - ) - - assert result["type"] == data_entry_flow.FlowResultType.CREATE_ENTRY - assert entry.options == { - CONF_STATION_UPDATES: True, + CONF_STATION_UPDATES: expected, } await hass.async_block_till_done()