Use EntityDescription - blink (#54360)

homeassistant/components/blink/binary_sensor.py

@@ -1,47 +1,60 @@
 """Support for Blink system camera control."""
+from __future__ import annotations
+
 from homeassistant.components.binary_sensor import (
     DEVICE_CLASS_BATTERY,
     DEVICE_CLASS_MOTION,
     BinarySensorEntity,
+    BinarySensorEntityDescription,
 )
 
 from .const import DOMAIN, TYPE_BATTERY, TYPE_CAMERA_ARMED, TYPE_MOTION_DETECTED
 
-BINARY_SENSORS = {
-    TYPE_BATTERY: ["Battery", DEVICE_CLASS_BATTERY],
-    TYPE_CAMERA_ARMED: ["Camera Armed", None],
-    TYPE_MOTION_DETECTED: ["Motion Detected", DEVICE_CLASS_MOTION],
-}
+BINARY_SENSORS_TYPES: tuple[BinarySensorEntityDescription, ...] = (
+    BinarySensorEntityDescription(
+        key=TYPE_BATTERY,
+        name="Battery",
+        device_class=DEVICE_CLASS_BATTERY,
+    ),
+    BinarySensorEntityDescription(
+        key=TYPE_CAMERA_ARMED,
+        name="Camera Armed",
+    ),
+    BinarySensorEntityDescription(
+        key=TYPE_MOTION_DETECTED,
+        name="Motion Detected",
+        device_class=DEVICE_CLASS_MOTION,
+    ),
+)
 
 
 async def async_setup_entry(hass, config, async_add_entities):
     """Set up the blink binary sensors."""
     data = hass.data[DOMAIN][config.entry_id]
 
-    entities = []
-    for camera in data.cameras:
-        for sensor_type in BINARY_SENSORS:
-            entities.append(BlinkBinarySensor(data, camera, sensor_type))
+    entities = [
+        BlinkBinarySensor(data, camera, description)
+        for camera in data.cameras
+        for description in BINARY_SENSORS_TYPES
+    ]
     async_add_entities(entities)
 
 
 class BlinkBinarySensor(BinarySensorEntity):
     """Representation of a Blink binary sensor."""
 
-    def __init__(self, data, camera, sensor_type):
+    def __init__(self, data, camera, description: BinarySensorEntityDescription):
         """Initialize the sensor."""
         self.data = data
-        self._type = sensor_type
-        name, device_class = BINARY_SENSORS[sensor_type]
-        self._attr_name = f"{DOMAIN} {camera} {name}"
-        self._attr_device_class = device_class
+        self.entity_description = description
+        self._attr_name = f"{DOMAIN} {camera} {description.name}"
         self._camera = data.cameras[camera]
-        self._attr_unique_id = f"{self._camera.serial}-{sensor_type}"
+        self._attr_unique_id = f"{self._camera.serial}-{description.key}"
 
     def update(self):
         """Update sensor state."""
         self.data.refresh()
-        state = self._camera.attributes[self._type]
-        if self._type == TYPE_BATTERY:
+        state = self._camera.attributes[self.entity_description.key]
+        if self.entity_description.key == TYPE_BATTERY:
             state = state != "ok"
         self._attr_is_on = state

homeassistant/components/blink/sensor.py

@@ -1,7 +1,9 @@
 """Support for Blink system camera sensors."""
+from __future__ import annotations
+
 import logging
 
-from homeassistant.components.sensor import SensorEntity
+from homeassistant.components.sensor import SensorEntity, SensorEntityDescription
 from homeassistant.const import (
     DEVICE_CLASS_SIGNAL_STRENGTH,
     DEVICE_CLASS_TEMPERATURE,
@@ -13,23 +15,30 @@ from .const import DOMAIN, TYPE_TEMPERATURE, TYPE_WIFI_STRENGTH
 
 _LOGGER = logging.getLogger(__name__)
 
-SENSORS = {
-    TYPE_TEMPERATURE: ["Temperature", TEMP_FAHRENHEIT, DEVICE_CLASS_TEMPERATURE],
-    TYPE_WIFI_STRENGTH: [
-        "Wifi Signal",
-        SIGNAL_STRENGTH_DECIBELS_MILLIWATT,
-        DEVICE_CLASS_SIGNAL_STRENGTH,
-    ],
-}
+SENSOR_TYPES: tuple[SensorEntityDescription, ...] = (
+    SensorEntityDescription(
+        key=TYPE_TEMPERATURE,
+        name="Temperature",
+        native_unit_of_measurement=TEMP_FAHRENHEIT,
+        device_class=DEVICE_CLASS_TEMPERATURE,
+    ),
+    SensorEntityDescription(
+        key=TYPE_WIFI_STRENGTH,
+        name="Wifi Signal",
+        native_unit_of_measurement=SIGNAL_STRENGTH_DECIBELS_MILLIWATT,
+        device_class=DEVICE_CLASS_SIGNAL_STRENGTH,
+    ),
+)
 
 
 async def async_setup_entry(hass, config, async_add_entities):
     """Initialize a Blink sensor."""
     data = hass.data[DOMAIN][config.entry_id]
-    entities = []
-    for camera in data.cameras:
-        for sensor_type in SENSORS:
-            entities.append(BlinkSensor(data, camera, sensor_type))
+    entities = [
+        BlinkSensor(data, camera, description)
+        for camera in data.cameras
+        for description in SENSOR_TYPES
+    ]
 
     async_add_entities(entities)
 
@@ -37,17 +46,17 @@ async def async_setup_entry(hass, config, async_add_entities):
 class BlinkSensor(SensorEntity):
     """A Blink camera sensor."""
 
-    def __init__(self, data, camera, sensor_type):
+    def __init__(self, data, camera, description: SensorEntityDescription):
         """Initialize sensors from Blink camera."""
-        name, units, device_class = SENSORS[sensor_type]
-        self._attr_name = f"{DOMAIN} {camera} {name}"
-        self._attr_device_class = device_class
+        self.entity_description = description
+        self._attr_name = f"{DOMAIN} {camera} {description.name}"
         self.data = data
         self._camera = data.cameras[camera]
-        self._attr_native_unit_of_measurement = units
-        self._attr_unique_id = f"{self._camera.serial}-{sensor_type}"
+        self._attr_unique_id = f"{self._camera.serial}-{description.key}"
         self._sensor_key = (
-            "temperature_calibrated" if sensor_type == "temperature" else sensor_type
+            "temperature_calibrated"
+            if description.key == "temperature"
+            else description.key
         )
 
     def update(self):