From b4a7980084b5a2c7d2f0fdae293247b1f39f7385 Mon Sep 17 00:00:00 2001 From: Joakim Plate Date: Mon, 29 Apr 2019 03:27:35 +0200 Subject: [PATCH] Update Philips js to v0.0.8 (#23462) * Don't send volume on volume set This needs updated lib * Bump version and avoid getting channels explicitly * Add myself as codeowner * Use version 0.0.8 instead which doesn't reuse session Some TV's doesn't play nice with HTTP/1.1 connection re-use. * Add new requirement to requirements_all.txt --- CODEOWNERS | 1 + homeassistant/components/philips_js/manifest.json | 4 ++-- homeassistant/components/philips_js/media_player.py | 4 +--- requirements_all.txt | 2 +- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 38de5b1fe6f..979805a65dd 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -169,6 +169,7 @@ homeassistant/components/owlet/* @oblogic7 homeassistant/components/panel_custom/* @home-assistant/core homeassistant/components/panel_iframe/* @home-assistant/core homeassistant/components/persistent_notification/* @home-assistant/core +homeassistant/components/philips_js/* @elupus homeassistant/components/pi_hole/* @fabaff homeassistant/components/plant/* @ChristianKuehnel homeassistant/components/point/* @fredrike diff --git a/homeassistant/components/philips_js/manifest.json b/homeassistant/components/philips_js/manifest.json index 16a3dbd119d..0b1579a139d 100644 --- a/homeassistant/components/philips_js/manifest.json +++ b/homeassistant/components/philips_js/manifest.json @@ -3,8 +3,8 @@ "name": "Philips js", "documentation": "https://www.home-assistant.io/components/philips_js", "requirements": [ - "ha-philipsjs==0.0.6" + "ha-philipsjs==0.0.8" ], "dependencies": [], - "codeowners": [] + "codeowners": ["@elupus"] } diff --git a/homeassistant/components/philips_js/media_player.py b/homeassistant/components/philips_js/media_player.py index 0b0b1de4275..743992990ca 100644 --- a/homeassistant/components/philips_js/media_player.py +++ b/homeassistant/components/philips_js/media_player.py @@ -197,7 +197,7 @@ class PhilipsTV(MediaPlayerDevice): def mute_volume(self, mute): """Send mute command.""" - self._tv.setVolume(self._tv.volume, mute) + self._tv.setVolume(None, mute) self._update_soon(DELAY_ACTION_DEFAULT) def set_volume_level(self, volume): @@ -270,8 +270,6 @@ class PhilipsTV(MediaPlayerDevice): def update(self): """Get the latest data and update device state.""" self._tv.update() - self._tv.getChannelId() - self._tv.getChannels() self._sources = { srcid: source['name'] or "Source {}".format(srcid) diff --git a/requirements_all.txt b/requirements_all.txt index 7203d967e53..0bd974f0de7 100644 --- a/requirements_all.txt +++ b/requirements_all.txt @@ -515,7 +515,7 @@ gstreamer-player==1.1.2 ha-ffmpeg==2.0 # homeassistant.components.philips_js -ha-philipsjs==0.0.6 +ha-philipsjs==0.0.8 # homeassistant.components.habitica habitipy==0.2.0