Add option to specify Reolink Basic Service Port (#137603)

* Allow changing the baichuan port

* styling

* Add description

* Add tests

* Review feedback

* capital letters

Co-authored-by: Robert Resch <robert@resch.dev>

---------

Co-authored-by: Robert Resch <robert@resch.dev>
This commit is contained in:
starkillerOG
2025-03-16 19:51:06 +01:00
committed by GitHub
parent 8a552aef9d
commit b5fa3e74c0
9 changed files with 67 additions and 7 deletions

View File

@@ -19,6 +19,7 @@ from homeassistant import config_entries
from homeassistant.components.reolink import DEVICE_UPDATE_INTERVAL
from homeassistant.components.reolink.config_flow import DEFAULT_PROTOCOL
from homeassistant.components.reolink.const import (
CONF_BC_PORT,
CONF_SUPPORTS_PRIVACY_MODE,
CONF_USE_HTTPS,
DOMAIN,
@@ -40,6 +41,7 @@ from homeassistant.helpers.service_info.dhcp import DhcpServiceInfo
from .conftest import (
DHCP_FORMATTED_MAC,
TEST_BC_PORT,
TEST_HOST,
TEST_HOST2,
TEST_MAC,
@@ -88,6 +90,7 @@ async def test_config_flow_manual_success(
CONF_PORT: TEST_PORT,
CONF_USE_HTTPS: TEST_USE_HTTPS,
CONF_SUPPORTS_PRIVACY_MODE: TEST_PRIVACY,
CONF_BC_PORT: TEST_BC_PORT,
}
assert result["options"] == {
CONF_PROTOCOL: DEFAULT_PROTOCOL,
@@ -140,6 +143,7 @@ async def test_config_flow_privacy_success(
CONF_PORT: TEST_PORT,
CONF_USE_HTTPS: TEST_USE_HTTPS,
CONF_SUPPORTS_PRIVACY_MODE: TEST_PRIVACY,
CONF_BC_PORT: TEST_BC_PORT,
}
assert result["options"] == {
CONF_PROTOCOL: DEFAULT_PROTOCOL,
@@ -290,6 +294,7 @@ async def test_config_flow_errors(
CONF_HOST: TEST_HOST,
CONF_PORT: TEST_PORT,
CONF_USE_HTTPS: TEST_USE_HTTPS,
CONF_BC_PORT: TEST_BC_PORT,
},
)
@@ -302,6 +307,7 @@ async def test_config_flow_errors(
CONF_PORT: TEST_PORT,
CONF_USE_HTTPS: TEST_USE_HTTPS,
CONF_SUPPORTS_PRIVACY_MODE: TEST_PRIVACY,
CONF_BC_PORT: TEST_BC_PORT,
}
assert result["options"] == {
CONF_PROTOCOL: DEFAULT_PROTOCOL,
@@ -322,6 +328,7 @@ async def test_options_flow(hass: HomeAssistant, mock_setup_entry: MagicMock) ->
CONF_PASSWORD: TEST_PASSWORD,
CONF_PORT: TEST_PORT,
CONF_USE_HTTPS: TEST_USE_HTTPS,
CONF_BC_PORT: TEST_BC_PORT,
},
options={
CONF_PROTOCOL: "rtsp",
@@ -360,6 +367,7 @@ async def test_reauth(hass: HomeAssistant, mock_setup_entry: MagicMock) -> None:
CONF_PASSWORD: TEST_PASSWORD,
CONF_PORT: TEST_PORT,
CONF_USE_HTTPS: TEST_USE_HTTPS,
CONF_BC_PORT: TEST_BC_PORT,
},
options={
CONF_PROTOCOL: DEFAULT_PROTOCOL,
@@ -405,6 +413,7 @@ async def test_reauth_abort_unique_id_mismatch(
CONF_PASSWORD: TEST_PASSWORD,
CONF_PORT: TEST_PORT,
CONF_USE_HTTPS: TEST_USE_HTTPS,
CONF_BC_PORT: TEST_BC_PORT,
},
options={
CONF_PROTOCOL: DEFAULT_PROTOCOL,
@@ -474,6 +483,7 @@ async def test_dhcp_flow(hass: HomeAssistant, mock_setup_entry: MagicMock) -> No
CONF_PORT: TEST_PORT,
CONF_USE_HTTPS: TEST_USE_HTTPS,
CONF_SUPPORTS_PRIVACY_MODE: TEST_PRIVACY,
CONF_BC_PORT: TEST_BC_PORT,
}
assert result["options"] == {
CONF_PROTOCOL: DEFAULT_PROTOCOL,
@@ -496,6 +506,7 @@ async def test_dhcp_ip_update_aborted_if_wrong_mac(
CONF_PASSWORD: TEST_PASSWORD,
CONF_PORT: TEST_PORT,
CONF_USE_HTTPS: TEST_USE_HTTPS,
CONF_BC_PORT: TEST_BC_PORT,
},
options={
CONF_PROTOCOL: DEFAULT_PROTOCOL,
@@ -536,6 +547,7 @@ async def test_dhcp_ip_update_aborted_if_wrong_mac(
protocol=DEFAULT_PROTOCOL,
timeout=DEFAULT_TIMEOUT,
aiohttp_get_session_callback=ANY,
bc_port=TEST_BC_PORT,
)
assert expected_call in reolink_connect_class.call_args_list
@@ -593,6 +605,7 @@ async def test_dhcp_ip_update(
CONF_PASSWORD: TEST_PASSWORD,
CONF_PORT: TEST_PORT,
CONF_USE_HTTPS: TEST_USE_HTTPS,
CONF_BC_PORT: TEST_BC_PORT,
},
options={
CONF_PROTOCOL: DEFAULT_PROTOCOL,
@@ -635,6 +648,7 @@ async def test_dhcp_ip_update(
protocol=DEFAULT_PROTOCOL,
timeout=DEFAULT_TIMEOUT,
aiohttp_get_session_callback=ANY,
bc_port=TEST_BC_PORT,
)
assert expected_call in reolink_connect_class.call_args_list
@@ -671,6 +685,7 @@ async def test_dhcp_ip_update_ingnored_if_still_connected(
CONF_PASSWORD: TEST_PASSWORD,
CONF_PORT: TEST_PORT,
CONF_USE_HTTPS: TEST_USE_HTTPS,
CONF_BC_PORT: TEST_BC_PORT,
},
options={
CONF_PROTOCOL: DEFAULT_PROTOCOL,
@@ -702,6 +717,7 @@ async def test_dhcp_ip_update_ingnored_if_still_connected(
protocol=DEFAULT_PROTOCOL,
timeout=DEFAULT_TIMEOUT,
aiohttp_get_session_callback=ANY,
bc_port=TEST_BC_PORT,
)
assert expected_call in reolink_connect_class.call_args_list
@@ -731,6 +747,7 @@ async def test_reconfig(hass: HomeAssistant, mock_setup_entry: MagicMock) -> Non
CONF_PASSWORD: TEST_PASSWORD,
CONF_PORT: TEST_PORT,
CONF_USE_HTTPS: TEST_USE_HTTPS,
CONF_BC_PORT: TEST_BC_PORT,
},
options={
CONF_PROTOCOL: DEFAULT_PROTOCOL,
@@ -777,6 +794,7 @@ async def test_reconfig_abort_unique_id_mismatch(
CONF_PASSWORD: TEST_PASSWORD,
CONF_PORT: TEST_PORT,
CONF_USE_HTTPS: TEST_USE_HTTPS,
CONF_BC_PORT: TEST_BC_PORT,
},
options={
CONF_PROTOCOL: DEFAULT_PROTOCOL,