From b637b48bd8684f1937d2030778e3ed399a44ae4d Mon Sep 17 00:00:00 2001 From: Malte Franken Date: Tue, 9 Oct 2018 01:13:08 +1100 Subject: [PATCH] emptying device state attributes if the update from the feed fails (#17249) --- homeassistant/components/sensor/geo_rss_events.py | 1 + tests/components/sensor/test_geo_rss_events.py | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/homeassistant/components/sensor/geo_rss_events.py b/homeassistant/components/sensor/geo_rss_events.py index 5085e113e92..22b4c71a705 100644 --- a/homeassistant/components/sensor/geo_rss_events.py +++ b/homeassistant/components/sensor/geo_rss_events.py @@ -145,3 +145,4 @@ class GeoRssServiceSensor(Entity): # If no events were found due to an error then just set state to # zero. self._state = 0 + self._state_attributes = {} diff --git a/tests/components/sensor/test_geo_rss_events.py b/tests/components/sensor/test_geo_rss_events.py index 21538d458bc..3362f799392 100644 --- a/tests/components/sensor/test_geo_rss_events.py +++ b/tests/components/sensor/test_geo_rss_events.py @@ -123,6 +123,10 @@ class TestGeoRssServiceUpdater(unittest.TestCase): assert len(all_states) == 1 state = self.hass.states.get("sensor.event_service_any") assert int(state.state) == 0 + assert state.attributes == { + ATTR_FRIENDLY_NAME: "Event Service Any", + ATTR_UNIT_OF_MEASUREMENT: "Events", + ATTR_ICON: "mdi:alert"} @mock.patch('georss_client.generic_feed.GenericFeed') def test_setup_with_categories(self, mock_feed):