jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-15 17:27:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Fix missing id in Habitica completed todos API response" (#126142)

Browse Source 
Revert "Fix missing id in Habitica completed todos API response (#124565)"

This reverts commit c9e7c76ee55c628e59c659bd331ab6bf0352bed6.
This commit is contained in:
Mr. Bubbles 2024-09-19 10:59:54 +02:00 committed by GitHub
parent 3c99fad6b9
commit b787c2617b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 15 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
homeassistant/components/habitica/coordinator.py
View File

@ -56,14 +56,7 @@ class HabiticaDataUpdateCoordinator(DataUpdateCoordinator[HabiticaData]):
try: try:
user_response = await self.api.user.get() user_response = await self.api.user.get()
tasks_response = await self.api.tasks.user.get() tasks_response = await self.api.tasks.user.get()
tasks_response.extend( tasks_response.extend(await self.api.tasks.user.get(type="completedTodos"))
[
{"id": task["_id"], **task}
for task in await self.api.tasks.user.get(type="completedTodos")
if task.get("_id")
]
)
except ClientResponseError as error: except ClientResponseError as error:
if error.status == HTTPStatus.TOO_MANY_REQUESTS: if error.status == HTTPStatus.TOO_MANY_REQUESTS:
_LOGGER.debug("Currently rate limited, skipping update") _LOGGER.debug("Currently rate limited, skipping update")

28
tests/components/habitica/test_init.py
View File

@ -74,20 +74,7 @@ def common_requests(aioclient_mock: AiohttpClientMocker) -> AiohttpClientMocker:
} }
}, },
) )
aioclient_mock.get(
"https://habitica.com/api/v3/tasks/user?type=completedTodos",
json={
"data": [
{
"text": "this is a mock todo #5",
"id": 5,
"_id": 5,
"type": "todo",
"completed": True,
}
]
},
)
aioclient_mock.get( aioclient_mock.get(
"https://habitica.com/api/v3/tasks/user", "https://habitica.com/api/v3/tasks/user",
json={ json={
@ -102,6 +89,19 @@ def common_requests(aioclient_mock: AiohttpClientMocker) -> AiohttpClientMocker:
] ]
}, },
) )
aioclient_mock.get(
"https://habitica.com/api/v3/tasks/user?type=completedTodos",
json={
"data": [
{
"text": "this is a mock todo #5",
"id": 5,
"type": "todo",
"completed": True,
}
]
},
)
aioclient_mock.post( aioclient_mock.post(
"https://habitica.com/api/v3/tasks/user", "https://habitica.com/api/v3/tasks/user",