jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-18 18:57:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent device tracker from creating invalid YAML (#1774)

Browse Source
This commit is contained in:
Paulus Schoutsen 2016-04-09 13:38:51 -07:00
parent 446d367aeb
commit b87e2437aa
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
homeassistant/components/device_tracker/__init__.py
View File

@ -204,6 +204,7 @@ class DeviceTracker(object):
return return
# If no device can be found, create it # If no device can be found, create it
dev_id = util.ensure_unique_string(dev_id, self.devices.keys())
device = Device( device = Device(
self.hass, self.consider_home, self.home_range, self.track_new, self.hass, self.consider_home, self.home_range, self.track_new,
dev_id, mac, (host_name or dev_id).replace('_', ' ')) dev_id, mac, (host_name or dev_id).replace('_', ' '))

13
tests/components/device_tracker/test_init.py
View File

@ -197,3 +197,16 @@ class TestComponentsDeviceTracker(unittest.TestCase):
mock_see.assert_called_once_with( mock_see.assert_called_once_with(
mac=mac, dev_id=dev_id, host_name=host_name, mac=mac, dev_id=dev_id, host_name=host_name,
location_name=location_name, gps=gps) location_name=location_name, gps=gps)
def test_not_write_duplicate_yaml_keys(self):
"""Test that the device tracker will not generate invalid YAML."""
self.assertTrue(device_tracker.setup(self.hass, {}))
device_tracker.see(self.hass, 'mac_1', host_name='hello')
device_tracker.see(self.hass, 'mac_2', host_name='hello')
self.hass.pool.block_till_done()
config = device_tracker.load_config(self.yaml_devices, self.hass,
timedelta(seconds=0), 0)
assert len(config) == 2