From b8abc1350ae478c1e6dcdbe6ec5eff066dda0939 Mon Sep 17 00:00:00 2001 From: Joost Lekkerkerker Date: Fri, 7 Apr 2023 13:45:40 +0200 Subject: [PATCH] Move plant const to separate file (#91008) * Move plant const to separate file * Fix feedback * Fix feedback * Update homeassistant/components/plant/const.py Co-authored-by: epenet <6771947+epenet@users.noreply.github.com> --------- Co-authored-by: epenet <6771947+epenet@users.noreply.github.com> --- homeassistant/components/plant/__init__.py | 67 ++++++++++------------ homeassistant/components/plant/const.py | 37 ++++++++++++ 2 files changed, 67 insertions(+), 37 deletions(-) create mode 100644 homeassistant/components/plant/const.py diff --git a/homeassistant/components/plant/__init__.py b/homeassistant/components/plant/__init__.py index 35273e6fce0..e385156c6d1 100644 --- a/homeassistant/components/plant/__init__.py +++ b/homeassistant/components/plant/__init__.py @@ -8,7 +8,6 @@ import voluptuous as vol from homeassistant.components.recorder import get_instance, history from homeassistant.const import ( - ATTR_TEMPERATURE, ATTR_UNIT_OF_MEASUREMENT, CONDUCTIVITY, CONF_SENSORS, @@ -29,48 +28,44 @@ from homeassistant.helpers.event import async_track_state_change_event from homeassistant.helpers.typing import ConfigType from homeassistant.util import dt as dt_util +from .const import ( + ATTR_DICT_OF_UNITS_OF_MEASUREMENT, + ATTR_MAX_BRIGHTNESS_HISTORY, + ATTR_PROBLEM, + ATTR_SENSORS, + CONF_CHECK_DAYS, + CONF_MAX_BRIGHTNESS, + CONF_MAX_CONDUCTIVITY, + CONF_MAX_MOISTURE, + CONF_MAX_TEMPERATURE, + CONF_MIN_BATTERY_LEVEL, + CONF_MIN_BRIGHTNESS, + CONF_MIN_CONDUCTIVITY, + CONF_MIN_MOISTURE, + CONF_MIN_TEMPERATURE, + DEFAULT_CHECK_DAYS, + DEFAULT_MAX_CONDUCTIVITY, + DEFAULT_MAX_MOISTURE, + DEFAULT_MIN_BATTERY_LEVEL, + DEFAULT_MIN_CONDUCTIVITY, + DEFAULT_MIN_MOISTURE, + DOMAIN, + PROBLEM_NONE, + READING_BATTERY, + READING_BRIGHTNESS, + READING_CONDUCTIVITY, + READING_MOISTURE, + READING_TEMPERATURE, +) + _LOGGER = logging.getLogger(__name__) -DEFAULT_NAME = "plant" - -READING_BATTERY = "battery" -READING_TEMPERATURE = ATTR_TEMPERATURE -READING_MOISTURE = "moisture" -READING_CONDUCTIVITY = "conductivity" -READING_BRIGHTNESS = "brightness" - -ATTR_PROBLEM = "problem" -ATTR_SENSORS = "sensors" -PROBLEM_NONE = "none" -ATTR_MAX_BRIGHTNESS_HISTORY = "max_brightness" - -# we're not returning only one value, we're returning a dict here. So we need -# to have a separate literal for it to avoid confusion. -ATTR_DICT_OF_UNITS_OF_MEASUREMENT = "unit_of_measurement_dict" - -CONF_MIN_BATTERY_LEVEL = f"min_{READING_BATTERY}" -CONF_MIN_TEMPERATURE = f"min_{READING_TEMPERATURE}" -CONF_MAX_TEMPERATURE = f"max_{READING_TEMPERATURE}" -CONF_MIN_MOISTURE = f"min_{READING_MOISTURE}" -CONF_MAX_MOISTURE = f"max_{READING_MOISTURE}" -CONF_MIN_CONDUCTIVITY = f"min_{READING_CONDUCTIVITY}" -CONF_MAX_CONDUCTIVITY = f"max_{READING_CONDUCTIVITY}" -CONF_MIN_BRIGHTNESS = f"min_{READING_BRIGHTNESS}" -CONF_MAX_BRIGHTNESS = f"max_{READING_BRIGHTNESS}" -CONF_CHECK_DAYS = "check_days" - CONF_SENSOR_BATTERY_LEVEL = READING_BATTERY CONF_SENSOR_MOISTURE = READING_MOISTURE CONF_SENSOR_CONDUCTIVITY = READING_CONDUCTIVITY CONF_SENSOR_TEMPERATURE = READING_TEMPERATURE CONF_SENSOR_BRIGHTNESS = READING_BRIGHTNESS -DEFAULT_MIN_BATTERY_LEVEL = 20 -DEFAULT_MIN_MOISTURE = 20 -DEFAULT_MAX_MOISTURE = 60 -DEFAULT_MIN_CONDUCTIVITY = 500 -DEFAULT_MAX_CONDUCTIVITY = 3000 -DEFAULT_CHECK_DAYS = 3 SCHEMA_SENSORS = vol.Schema( { @@ -104,8 +99,6 @@ PLANT_SCHEMA = vol.Schema( } ) -DOMAIN = "plant" - CONFIG_SCHEMA = vol.Schema({DOMAIN: {cv.string: PLANT_SCHEMA}}, extra=vol.ALLOW_EXTRA) diff --git a/homeassistant/components/plant/const.py b/homeassistant/components/plant/const.py new file mode 100644 index 00000000000..0368c55e152 --- /dev/null +++ b/homeassistant/components/plant/const.py @@ -0,0 +1,37 @@ +"""Const for Plant.""" +from typing import Final + +DOMAIN: Final = "plant" + +READING_MOISTURE = "moisture" +READING_BATTERY = "battery" +READING_TEMPERATURE = "temperature" +READING_CONDUCTIVITY = "conductivity" +READING_BRIGHTNESS = "brightness" + +CONF_MIN_BATTERY_LEVEL = f"min_{READING_BATTERY}" +CONF_MIN_TEMPERATURE = f"min_{READING_TEMPERATURE}" +CONF_MAX_TEMPERATURE = f"max_{READING_TEMPERATURE}" +CONF_MIN_MOISTURE = f"min_{READING_MOISTURE}" +CONF_MAX_MOISTURE = f"max_{READING_MOISTURE}" +CONF_MIN_CONDUCTIVITY = f"min_{READING_CONDUCTIVITY}" +CONF_MAX_CONDUCTIVITY = f"max_{READING_CONDUCTIVITY}" +CONF_MIN_BRIGHTNESS = f"min_{READING_BRIGHTNESS}" +CONF_MAX_BRIGHTNESS = f"max_{READING_BRIGHTNESS}" +CONF_CHECK_DAYS = "check_days" + +DEFAULT_MIN_BATTERY_LEVEL = 20 +DEFAULT_MIN_MOISTURE = 20 +DEFAULT_MAX_MOISTURE = 60 +DEFAULT_MIN_CONDUCTIVITY = 500 +DEFAULT_MAX_CONDUCTIVITY = 3000 +DEFAULT_CHECK_DAYS = 3 + +ATTR_PROBLEM = "problem" +ATTR_SENSORS = "sensors" +PROBLEM_NONE = "none" +ATTR_MAX_BRIGHTNESS_HISTORY = "max_brightness" + +# we're not returning only one value, we're returning a dict here. So we need +# to have a separate literal for it to avoid confusion. +ATTR_DICT_OF_UNITS_OF_MEASUREMENT = "unit_of_measurement_dict"