From b92fc42f0f40c2ba9391e5e289e058e690f6081b Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Sat, 2 Apr 2022 21:48:32 -0600 Subject: [PATCH] Exclude static climate attributes from being recorded in the database (#69158) --- homeassistant/components/climate/recorder.py | 32 ++++++++++ tests/components/climate/test_recorder.py | 61 ++++++++++++++++++++ 2 files changed, 93 insertions(+) create mode 100644 homeassistant/components/climate/recorder.py create mode 100644 tests/components/climate/test_recorder.py diff --git a/homeassistant/components/climate/recorder.py b/homeassistant/components/climate/recorder.py new file mode 100644 index 00000000000..879e6bfbbac --- /dev/null +++ b/homeassistant/components/climate/recorder.py @@ -0,0 +1,32 @@ +"""Integration platform for recorder.""" +from __future__ import annotations + +from homeassistant.core import HomeAssistant, callback + +from .const import ( + ATTR_FAN_MODES, + ATTR_HVAC_MODES, + ATTR_MAX_HUMIDITY, + ATTR_MAX_TEMP, + ATTR_MIN_HUMIDITY, + ATTR_MIN_TEMP, + ATTR_PRESET_MODES, + ATTR_SWING_MODES, + ATTR_TARGET_TEMP_STEP, +) + + +@callback +def exclude_attributes(hass: HomeAssistant) -> set[str]: + """Exclude static attributes from being recorded in the database.""" + return { + ATTR_HVAC_MODES, + ATTR_FAN_MODES, + ATTR_SWING_MODES, + ATTR_MIN_TEMP, + ATTR_MAX_TEMP, + ATTR_MIN_HUMIDITY, + ATTR_MAX_HUMIDITY, + ATTR_TARGET_TEMP_STEP, + ATTR_PRESET_MODES, + } diff --git a/tests/components/climate/test_recorder.py b/tests/components/climate/test_recorder.py new file mode 100644 index 00000000000..f1642fca240 --- /dev/null +++ b/tests/components/climate/test_recorder.py @@ -0,0 +1,61 @@ +"""The tests for climate recorder.""" +from __future__ import annotations + +from datetime import timedelta + +from homeassistant.components import climate +from homeassistant.components.climate.const import ( + ATTR_FAN_MODES, + ATTR_HVAC_MODES, + ATTR_MAX_HUMIDITY, + ATTR_MAX_TEMP, + ATTR_MIN_HUMIDITY, + ATTR_MIN_TEMP, + ATTR_PRESET_MODES, + ATTR_SWING_MODES, + ATTR_TARGET_TEMP_STEP, +) +from homeassistant.components.recorder.models import StateAttributes, States +from homeassistant.components.recorder.util import session_scope +from homeassistant.const import ATTR_FRIENDLY_NAME +from homeassistant.core import State +from homeassistant.setup import async_setup_component +from homeassistant.util import dt as dt_util + +from tests.common import async_fire_time_changed, async_init_recorder_component +from tests.components.recorder.common import async_wait_recording_done_without_instance + + +async def test_exclude_attributes(hass): + """Test climate registered attributes to be excluded.""" + await async_init_recorder_component(hass) + await async_setup_component( + hass, climate.DOMAIN, {climate.DOMAIN: {"platform": "demo"}} + ) + await hass.async_block_till_done() + async_fire_time_changed(hass, dt_util.utcnow() + timedelta(minutes=5)) + await hass.async_block_till_done() + await async_wait_recording_done_without_instance(hass) + + def _fetch_states() -> list[State]: + with session_scope(hass=hass) as session: + native_states = [] + for db_state, db_state_attributes in session.query(States, StateAttributes): + state = db_state.to_native() + state.attributes = db_state_attributes.to_native() + native_states.append(state) + return native_states + + states: list[State] = await hass.async_add_executor_job(_fetch_states) + assert len(states) > 1 + for state in states: + assert ATTR_PRESET_MODES not in state.attributes + assert ATTR_HVAC_MODES not in state.attributes + assert ATTR_FAN_MODES not in state.attributes + assert ATTR_SWING_MODES not in state.attributes + assert ATTR_MIN_TEMP not in state.attributes + assert ATTR_MAX_TEMP not in state.attributes + assert ATTR_MIN_HUMIDITY not in state.attributes + assert ATTR_MAX_HUMIDITY not in state.attributes + assert ATTR_TARGET_TEMP_STEP not in state.attributes + assert ATTR_FRIENDLY_NAME in state.attributes