From b9e16d54c4416c4c2319a69b2280608e7985eec2 Mon Sep 17 00:00:00 2001
From: Jan-Philipp Benecke <jan-philipp@bnck.me>
Date: Sun, 3 Aug 2025 20:06:14 +0200
Subject: [PATCH] Add jitter sensor to Ping integration (#149899)

---
 homeassistant/components/ping/helpers.py      |  1 +
 homeassistant/components/ping/sensor.py       | 11 ++++
 homeassistant/components/ping/strings.json    |  3 +
 .../ping/snapshots/test_sensor.ambr           | 55 +++++++++++++++++++
 tests/components/ping/test_sensor.py          |  1 +
 5 files changed, 71 insertions(+)

diff --git a/homeassistant/components/ping/helpers.py b/homeassistant/components/ping/helpers.py
index 996faa99c5b..8000cbcddde 100644
--- a/homeassistant/components/ping/helpers.py
+++ b/homeassistant/components/ping/helpers.py
@@ -79,6 +79,7 @@ class PingDataICMPLib(PingData):
             "min": data.min_rtt,
             "max": data.max_rtt,
             "avg": data.avg_rtt,
+            "jitter": data.jitter,
         }
 
 
diff --git a/homeassistant/components/ping/sensor.py b/homeassistant/components/ping/sensor.py
index 82d88064e02..b3866c9f0e7 100644
--- a/homeassistant/components/ping/sensor.py
+++ b/homeassistant/components/ping/sensor.py
@@ -71,6 +71,17 @@ SENSORS: tuple[PingSensorEntityDescription, ...] = (
         value_fn=lambda result: result.data.get("min"),
         has_fn=lambda result: "min" in result.data,
     ),
+    PingSensorEntityDescription(
+        key="jitter",
+        translation_key="jitter",
+        native_unit_of_measurement=UnitOfTime.MILLISECONDS,
+        state_class=SensorStateClass.MEASUREMENT,
+        device_class=SensorDeviceClass.DURATION,
+        entity_registry_enabled_default=False,
+        entity_category=EntityCategory.DIAGNOSTIC,
+        value_fn=lambda result: result.data.get("jitter"),
+        has_fn=lambda result: "jitter" in result.data,
+    ),
 )
 
 
diff --git a/homeassistant/components/ping/strings.json b/homeassistant/components/ping/strings.json
index c301a1b277d..4dc2e8ec7fc 100644
--- a/homeassistant/components/ping/strings.json
+++ b/homeassistant/components/ping/strings.json
@@ -12,6 +12,9 @@
       },
       "round_trip_time_min": {
         "name": "Round-trip time minimum"
+      },
+      "jitter": {
+        "name": "Jitter"
       }
     }
   },
diff --git a/tests/components/ping/snapshots/test_sensor.ambr b/tests/components/ping/snapshots/test_sensor.ambr
index f09bfe61065..8cb8642f13a 100644
--- a/tests/components/ping/snapshots/test_sensor.ambr
+++ b/tests/components/ping/snapshots/test_sensor.ambr
@@ -1,4 +1,59 @@
 # serializer version: 1
+# name: test_setup_and_update[jitter]
+  EntityRegistryEntrySnapshot({
+    'aliases': set({
+    }),
+    'area_id': None,
+    'capabilities': dict({
+      'state_class': <SensorStateClass.MEASUREMENT: 'measurement'>,
+    }),
+    'config_entry_id': <ANY>,
+    'config_subentry_id': <ANY>,
+    'device_class': None,
+    'device_id': <ANY>,
+    'disabled_by': None,
+    'domain': 'sensor',
+    'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
+    'entity_id': 'sensor.10_10_10_10_jitter',
+    'has_entity_name': True,
+    'hidden_by': None,
+    'icon': None,
+    'id': <ANY>,
+    'labels': set({
+    }),
+    'name': None,
+    'options': dict({
+      'sensor': dict({
+        'suggested_display_precision': 0,
+      }),
+    }),
+    'original_device_class': <SensorDeviceClass.DURATION: 'duration'>,
+    'original_icon': None,
+    'original_name': 'Jitter',
+    'platform': 'ping',
+    'previous_unique_id': None,
+    'suggested_object_id': None,
+    'supported_features': 0,
+    'translation_key': 'jitter',
+    'unit_of_measurement': <UnitOfTime.MILLISECONDS: 'ms'>,
+  })
+# ---
+# name: test_setup_and_update[jitter].1
+  StateSnapshot({
+    'attributes': ReadOnlyDict({
+      'device_class': 'duration',
+      'friendly_name': '10.10.10.10 Jitter',
+      'state_class': <SensorStateClass.MEASUREMENT: 'measurement'>,
+      'unit_of_measurement': <UnitOfTime.MILLISECONDS: 'ms'>,
+    }),
+    'context': <ANY>,
+    'entity_id': 'sensor.10_10_10_10_jitter',
+    'last_changed': <ANY>,
+    'last_reported': <ANY>,
+    'last_updated': <ANY>,
+    'state': '3.5',
+  })
+# ---
 # name: test_setup_and_update[round_trip_time_average]
   EntityRegistryEntrySnapshot({
     'aliases': set({
diff --git a/tests/components/ping/test_sensor.py b/tests/components/ping/test_sensor.py
index bdc8b7d28e4..95a31aa5c08 100644
--- a/tests/components/ping/test_sensor.py
+++ b/tests/components/ping/test_sensor.py
@@ -16,6 +16,7 @@ from homeassistant.helpers import entity_registry as er
         "round_trip_time_maximum",
         "round_trip_time_mean_deviation",  # should be None in the snapshot
         "round_trip_time_minimum",
+        "jitter",
     ],
 )
 async def test_setup_and_update(