From ba40340f82388b54b4c3c5adcb260d2fb6c8296a Mon Sep 17 00:00:00 2001 From: "Mr. Bubbles" Date: Wed, 26 Jun 2024 08:45:22 +0200 Subject: [PATCH] Align deviceinfo entries in pyLoad integration (#120478) --- homeassistant/components/pyload/button.py | 2 +- homeassistant/components/pyload/sensor.py | 14 +++++++++++--- tests/components/pyload/snapshots/test_button.ambr | 8 ++++---- 3 files changed, 16 insertions(+), 8 deletions(-) diff --git a/homeassistant/components/pyload/button.py b/homeassistant/components/pyload/button.py index 1f6bf3c3d10..0d8a232142a 100644 --- a/homeassistant/components/pyload/button.py +++ b/homeassistant/components/pyload/button.py @@ -99,7 +99,7 @@ class PyLoadBinarySensor(CoordinatorEntity[PyLoadCoordinator], ButtonEntity): model=SERVICE_NAME, configuration_url=coordinator.pyload.api_url, identifiers={(DOMAIN, coordinator.config_entry.entry_id)}, - translation_key=DOMAIN, + sw_version=coordinator.version, ) async def async_press(self) -> None: diff --git a/homeassistant/components/pyload/sensor.py b/homeassistant/components/pyload/sensor.py index c4fea3e43bb..3d681c4b65d 100644 --- a/homeassistant/components/pyload/sensor.py +++ b/homeassistant/components/pyload/sensor.py @@ -34,7 +34,15 @@ from homeassistant.helpers.typing import ConfigType, DiscoveryInfoType, StateTyp from homeassistant.helpers.update_coordinator import CoordinatorEntity from . import PyLoadConfigEntry -from .const import DEFAULT_HOST, DEFAULT_NAME, DEFAULT_PORT, DOMAIN, ISSUE_PLACEHOLDER +from .const import ( + DEFAULT_HOST, + DEFAULT_NAME, + DEFAULT_PORT, + DOMAIN, + ISSUE_PLACEHOLDER, + MANUFACTURER, + SERVICE_NAME, +) from .coordinator import PyLoadCoordinator @@ -175,8 +183,8 @@ class PyLoadSensor(CoordinatorEntity[PyLoadCoordinator], SensorEntity): self.entity_description = entity_description self.device_info = DeviceInfo( entry_type=DeviceEntryType.SERVICE, - manufacturer="PyLoad Team", - model="pyLoad", + manufacturer=MANUFACTURER, + model=SERVICE_NAME, configuration_url=coordinator.pyload.api_url, identifiers={(DOMAIN, coordinator.config_entry.entry_id)}, sw_version=coordinator.version, diff --git a/tests/components/pyload/snapshots/test_button.ambr b/tests/components/pyload/snapshots/test_button.ambr index c9a901aba15..bf1e1f59c98 100644 --- a/tests/components/pyload/snapshots/test_button.ambr +++ b/tests/components/pyload/snapshots/test_button.ambr @@ -35,7 +35,7 @@ # name: test_state[button.pyload_abort_all_running_downloads-state] StateSnapshot({ 'attributes': ReadOnlyDict({ - 'friendly_name': 'pyload Abort all running downloads', + 'friendly_name': 'pyLoad Abort all running downloads', }), 'context': , 'entity_id': 'button.pyload_abort_all_running_downloads', @@ -81,7 +81,7 @@ # name: test_state[button.pyload_delete_finished_files_packages-state] StateSnapshot({ 'attributes': ReadOnlyDict({ - 'friendly_name': 'pyload Delete finished files/packages', + 'friendly_name': 'pyLoad Delete finished files/packages', }), 'context': , 'entity_id': 'button.pyload_delete_finished_files_packages', @@ -127,7 +127,7 @@ # name: test_state[button.pyload_restart_all_failed_files-state] StateSnapshot({ 'attributes': ReadOnlyDict({ - 'friendly_name': 'pyload Restart all failed files', + 'friendly_name': 'pyLoad Restart all failed files', }), 'context': , 'entity_id': 'button.pyload_restart_all_failed_files', @@ -173,7 +173,7 @@ # name: test_state[button.pyload_restart_pyload_core-state] StateSnapshot({ 'attributes': ReadOnlyDict({ - 'friendly_name': 'pyload Restart pyload core', + 'friendly_name': 'pyLoad Restart pyload core', }), 'context': , 'entity_id': 'button.pyload_restart_pyload_core',