jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-15 17:27:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix missing await when running shutdown jobs (#106632)

Browse Source
This commit is contained in:
Erik Montnemery 2023-12-29 10:04:16 +01:00 committed by Franck Nijhof
parent f84d865c51
commit bb6f3bc830
No known key found for this signature in database
GPG Key ID: D62583BA8AB11CA3
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
homeassistant/core.py
View File

@ -889,7 +889,7 @@ class HomeAssistant:
continue continue
tasks.append(task_or_none) tasks.append(task_or_none)
if tasks: if tasks:
asyncio.gather(*tasks, return_exceptions=True) await asyncio.gather(*tasks, return_exceptions=True)
except asyncio.TimeoutError: except asyncio.TimeoutError:
_LOGGER.warning( _LOGGER.warning(
"Timed out waiting for shutdown jobs to complete, the shutdown will" "Timed out waiting for shutdown jobs to complete, the shutdown will"

3
tests/test_core.py
View File

@ -2605,6 +2605,9 @@ async def test_shutdown_job(hass: HomeAssistant) -> None:
evt = asyncio.Event() evt = asyncio.Event()
async def shutdown_func() -> None: async def shutdown_func() -> None:
# Sleep to ensure core is waiting for the task to finish
await asyncio.sleep(0.01)
# Set the event
evt.set() evt.set()
job = HassJob(shutdown_func, "shutdown_job") job = HassJob(shutdown_func, "shutdown_job")