From bc7d2d2195bca0d8f3fa3c3b3b8a4d868d66508a Mon Sep 17 00:00:00 2001 From: jan iversen Date: Tue, 16 Jul 2024 11:26:44 +0200 Subject: [PATCH] Remove modbus codeowner, and downgrade to quality "No score" (#122010) Co-authored-by: Franck Nijhof --- CODEOWNERS | 2 -- homeassistant/components/modbus/manifest.json | 4 ++-- script/hassfest/manifest.py | 4 ---- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 3a21c248a46..113c1fdc851 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -884,8 +884,6 @@ build.json @home-assistant/supervisor /tests/components/moat/ @bdraco /homeassistant/components/mobile_app/ @home-assistant/core /tests/components/mobile_app/ @home-assistant/core -/homeassistant/components/modbus/ @janiversen -/tests/components/modbus/ @janiversen /homeassistant/components/modem_callerid/ @tkdrob /tests/components/modem_callerid/ @tkdrob /homeassistant/components/modern_forms/ @wonderslug diff --git a/homeassistant/components/modbus/manifest.json b/homeassistant/components/modbus/manifest.json index 292a2ee86a8..4482801482f 100644 --- a/homeassistant/components/modbus/manifest.json +++ b/homeassistant/components/modbus/manifest.json @@ -1,10 +1,10 @@ { "domain": "modbus", "name": "Modbus", - "codeowners": ["@janiversen"], + "codeowners": [], "documentation": "https://www.home-assistant.io/integrations/modbus", "iot_class": "local_polling", "loggers": ["pymodbus"], - "quality_scale": "platinum", + "quality_scale": "silver", "requirements": ["pymodbus==3.6.9"] } diff --git a/script/hassfest/manifest.py b/script/hassfest/manifest.py index 8ff0750250f..1c01ee7cf58 100644 --- a/script/hassfest/manifest.py +++ b/script/hassfest/manifest.py @@ -120,10 +120,6 @@ NO_DIAGNOSTICS = [ "gdacs", "geonetnz_quakes", "hyperion", - # Modbus is excluded because it doesn't have to have a config flow - # according to ADR-0010, since it's a protocol integration. This - # means that it can't implement diagnostics. - "modbus", "nightscout", "pvpc_hourly_pricing", "risco",