From be4f9598f965007b6f09b7278ec5fd6298d85203 Mon Sep 17 00:00:00 2001 From: epenet <6771947+epenet@users.noreply.github.com> Date: Tue, 2 Aug 2022 16:28:41 +0200 Subject: [PATCH] Improve type hints in blinksticklight lights (#75999) --- homeassistant/components/blinksticklight/light.py | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/homeassistant/components/blinksticklight/light.py b/homeassistant/components/blinksticklight/light.py index 621bd01f874..8373d2990a1 100644 --- a/homeassistant/components/blinksticklight/light.py +++ b/homeassistant/components/blinksticklight/light.py @@ -1,6 +1,8 @@ """Support for Blinkstick lights.""" from __future__ import annotations +from typing import Any + from blinkstick import blinkstick import voluptuous as vol @@ -57,15 +59,15 @@ class BlinkStickLight(LightEntity): self._stick = stick self._attr_name = name - def update(self): + def update(self) -> None: """Read back the device state.""" rgb_color = self._stick.get_color() hsv = color_util.color_RGB_to_hsv(*rgb_color) self._attr_hs_color = hsv[:2] - self._attr_brightness = hsv[2] - self._attr_is_on = self.brightness > 0 + self._attr_brightness = int(hsv[2]) + self._attr_is_on = self.brightness is not None and self.brightness > 0 - def turn_on(self, **kwargs): + def turn_on(self, **kwargs: Any) -> None: """Turn the device on.""" if ATTR_HS_COLOR in kwargs: self._attr_hs_color = kwargs[ATTR_HS_COLOR] @@ -73,13 +75,15 @@ class BlinkStickLight(LightEntity): self._attr_brightness = kwargs[ATTR_BRIGHTNESS] else: self._attr_brightness = 255 + assert self.brightness is not None self._attr_is_on = self.brightness > 0 + assert self.hs_color rgb_color = color_util.color_hsv_to_RGB( self.hs_color[0], self.hs_color[1], self.brightness / 255 * 100 ) self._stick.set_color(red=rgb_color[0], green=rgb_color[1], blue=rgb_color[2]) - def turn_off(self, **kwargs): + def turn_off(self, **kwargs: Any) -> None: """Turn the device off.""" self._stick.turn_off()