Add icon translations to Twentemilieu (#112327)

homeassistant/components/twentemilieu/calendar.py

@@ -31,8 +31,8 @@ class TwenteMilieuCalendar(TwenteMilieuEntity, CalendarEntity):
     """Defines a Twente Milieu calendar."""
 
     _attr_has_entity_name = True
-    _attr_icon = "mdi:delete-empty"
     _attr_name = None
+    _attr_translation_key = "calendar"
 
     def __init__(
         self,

homeassistant/components/twentemilieu/icons.json

@@ -0,0 +1,26 @@
+{
+  "entity": {
+    "calendar": {
+      "calendar": {
+        "default": "mdi:delete-empty"
+      }
+    },
+    "sensor": {
+      "christmas_tree_pickup": {
+        "default": "mdi:pine-tree"
+      },
+      "non_recyclable_waste_pickup": {
+        "default": "mdi:delete-empty"
+      },
+      "organic_waste_pickup": {
+        "default": "mdi:delete-empty"
+      },
+      "paper_waste_pickup": {
+        "default": "mdi:delete-empty"
+      },
+      "packages_waste_pickup": {
+        "default": "mdi:delete-empty"
+      }
+    }
+  }
+}

homeassistant/components/twentemilieu/sensor.py

@@ -33,35 +33,30 @@ SENSORS: tuple[TwenteMilieuSensorDescription, ...] = (
         key="tree",
         translation_key="christmas_tree_pickup",
         waste_type=WasteType.TREE,
-        icon="mdi:pine-tree",
         device_class=SensorDeviceClass.DATE,
     ),
     TwenteMilieuSensorDescription(
         key="Non-recyclable",
         translation_key="non_recyclable_waste_pickup",
         waste_type=WasteType.NON_RECYCLABLE,
-        icon="mdi:delete-empty",
         device_class=SensorDeviceClass.DATE,
     ),
     TwenteMilieuSensorDescription(
         key="Organic",
         translation_key="organic_waste_pickup",
         waste_type=WasteType.ORGANIC,
-        icon="mdi:delete-empty",
         device_class=SensorDeviceClass.DATE,
     ),
     TwenteMilieuSensorDescription(
         key="Paper",
         translation_key="paper_waste_pickup",
         waste_type=WasteType.PAPER,
-        icon="mdi:delete-empty",
         device_class=SensorDeviceClass.DATE,
     ),
     TwenteMilieuSensorDescription(
         key="Plastic",
         translation_key="packages_waste_pickup",
         waste_type=WasteType.PACKAGES,
-        icon="mdi:delete-empty",
         device_class=SensorDeviceClass.DATE,
     ),
 )

tests/components/twentemilieu/snapshots/test_calendar.ambr

@@ -32,7 +32,6 @@
       'description': '',
       'end_time': '2022-01-07 00:00:00',
       'friendly_name': 'Twente Milieu',
-      'icon': 'mdi:delete-empty',
       'location': '',
       'message': 'Christmas tree pickup',
       'start_time': '2022-01-06 00:00:00',
@@ -67,12 +66,12 @@
     'options': dict({
     }),
     'original_device_class': None,
-    'original_icon': 'mdi:delete-empty',
+    'original_icon': None,
     'original_name': None,
     'platform': 'twentemilieu',
     'previous_unique_id': None,
     'supported_features': 0,
-    'translation_key': None,
+    'translation_key': 'calendar',
     'unique_id': '12345',
     'unit_of_measurement': None,
   })

tests/components/twentemilieu/snapshots/test_sensor.ambr

@@ -4,7 +4,6 @@
     'attributes': ReadOnlyDict({
       'device_class': 'date',
       'friendly_name': 'Twente Milieu Christmas tree pickup',
-      'icon': 'mdi:pine-tree',
     }),
     'context': <ANY>,
     'entity_id': 'sensor.twente_milieu_christmas_tree_pickup',
@@ -36,7 +35,7 @@
     'options': dict({
     }),
     'original_device_class': <SensorDeviceClass.DATE: 'date'>,
-    'original_icon': 'mdi:pine-tree',
+    'original_icon': None,
     'original_name': 'Christmas tree pickup',
     'platform': 'twentemilieu',
     'previous_unique_id': None,
@@ -81,7 +80,6 @@
     'attributes': ReadOnlyDict({
       'device_class': 'date',
       'friendly_name': 'Twente Milieu Non-recyclable waste pickup',
-      'icon': 'mdi:delete-empty',
     }),
     'context': <ANY>,
     'entity_id': 'sensor.twente_milieu_non_recyclable_waste_pickup',
@@ -113,7 +111,7 @@
     'options': dict({
     }),
     'original_device_class': <SensorDeviceClass.DATE: 'date'>,
-    'original_icon': 'mdi:delete-empty',
+    'original_icon': None,
     'original_name': 'Non-recyclable waste pickup',
     'platform': 'twentemilieu',
     'previous_unique_id': None,
@@ -158,7 +156,6 @@
     'attributes': ReadOnlyDict({
       'device_class': 'date',
       'friendly_name': 'Twente Milieu Organic waste pickup',
-      'icon': 'mdi:delete-empty',
     }),
     'context': <ANY>,
     'entity_id': 'sensor.twente_milieu_organic_waste_pickup',
@@ -190,7 +187,7 @@
     'options': dict({
     }),
     'original_device_class': <SensorDeviceClass.DATE: 'date'>,
-    'original_icon': 'mdi:delete-empty',
+    'original_icon': None,
     'original_name': 'Organic waste pickup',
     'platform': 'twentemilieu',
     'previous_unique_id': None,
@@ -235,7 +232,6 @@
     'attributes': ReadOnlyDict({
       'device_class': 'date',
       'friendly_name': 'Twente Milieu Packages waste pickup',
-      'icon': 'mdi:delete-empty',
     }),
     'context': <ANY>,
     'entity_id': 'sensor.twente_milieu_packages_waste_pickup',
@@ -267,7 +263,7 @@
     'options': dict({
     }),
     'original_device_class': <SensorDeviceClass.DATE: 'date'>,
-    'original_icon': 'mdi:delete-empty',
+    'original_icon': None,
     'original_name': 'Packages waste pickup',
     'platform': 'twentemilieu',
     'previous_unique_id': None,
@@ -312,7 +308,6 @@
     'attributes': ReadOnlyDict({
       'device_class': 'date',
       'friendly_name': 'Twente Milieu Paper waste pickup',
-      'icon': 'mdi:delete-empty',
     }),
     'context': <ANY>,
     'entity_id': 'sensor.twente_milieu_paper_waste_pickup',
@@ -344,7 +339,7 @@
     'options': dict({
     }),
     'original_device_class': <SensorDeviceClass.DATE: 'date'>,
-    'original_icon': 'mdi:delete-empty',
+    'original_icon': None,
     'original_name': 'Paper waste pickup',
     'platform': 'twentemilieu',
     'previous_unique_id': None,