jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-04-23 08:47:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix lingering timer in feedreader (#92180)

Browse Source
This commit is contained in:
epenet 2023-04-28 21:16:08 +02:00 committed by GitHub
parent 07d1a16efd
commit c303487c1b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
homeassistant/components/feedreader/__init__.py
View File

@ -93,7 +93,12 @@ class FeedManager:
def _init_regular_updates(self, hass: HomeAssistant) -> None:
"""Schedule regular updates at the top of the clock."""
track_time_interval(hass, lambda now: self._update(), self._scan_interval)
track_time_interval(
hass,
lambda now: self._update(),
self._scan_interval,
cancel_on_shutdown=True,
)
@property
def last_update_successful(self) -> bool:

8
tests/components/feedreader/test_init.py
View File

@ -85,7 +85,9 @@ async def test_setup_one_feed(hass: HomeAssistant) -> None:
assert await async_setup_component(hass, feedreader.DOMAIN, VALID_CONFIG_1)
await hass.async_block_till_done()
track_method.assert_called_once_with(hass, mock.ANY, DEFAULT_SCAN_INTERVAL)
track_method.assert_called_once_with(
hass, mock.ANY, DEFAULT_SCAN_INTERVAL, cancel_on_shutdown=True
)
async def test_setup_scan_interval(hass: HomeAssistant) -> None:
@ -96,7 +98,9 @@ async def test_setup_scan_interval(hass: HomeAssistant) -> None:
assert await async_setup_component(hass, feedreader.DOMAIN, VALID_CONFIG_2)
await hass.async_block_till_done()
track_method.assert_called_once_with(hass, mock.ANY, timedelta(seconds=60))
track_method.assert_called_once_with(
hass, mock.ANY, timedelta(seconds=60), cancel_on_shutdown=True
)
async def test_setup_max_entries(hass: HomeAssistant) -> None: