jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-04-27 02:37:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make eager_start default to True for async_create_task (#114995)

Browse Source
This commit is contained in:
J. Nick Koston 2024-04-06 09:15:40 -10:00 committed by GitHub
parent fa47e79292
commit c33a234048
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
homeassistant/core.py
View File

@ -719,7 +719,7 @@ class HomeAssistant:
self, self,
target: Coroutine[Any, Any, _R], target: Coroutine[Any, Any, _R],
name: str | None = None, name: str | None = None,
eager_start: bool = False, eager_start: bool = True,
) -> asyncio.Task[_R]: ) -> asyncio.Task[_R]:
"""Create a task from within the event loop. """Create a task from within the event loop.

6
tests/test_core.py
View File

@ -327,7 +327,7 @@ async def test_async_create_task_schedule_coroutine() -> None:
async def job(): async def job():
pass pass
ha.HomeAssistant.async_create_task(hass, job()) ha.HomeAssistant.async_create_task(hass, job(), eager_start=False)
assert len(hass.loop.call_soon.mock_calls) == 0 assert len(hass.loop.call_soon.mock_calls) == 0
assert len(hass.loop.create_task.mock_calls) == 1 assert len(hass.loop.create_task.mock_calls) == 1
assert len(hass.add_job.mock_calls) == 0 assert len(hass.add_job.mock_calls) == 0
@ -353,7 +353,9 @@ async def test_async_create_task_schedule_coroutine_with_name() -> None:
async def job(): async def job():
pass pass
task = ha.HomeAssistant.async_create_task(hass, job(), "named task") task = ha.HomeAssistant.async_create_task(
hass, job(), "named task", eager_start=False
)
assert len(hass.loop.call_soon.mock_calls) == 0 assert len(hass.loop.call_soon.mock_calls) == 0
assert len(hass.loop.create_task.mock_calls) == 1 assert len(hass.loop.create_task.mock_calls) == 1
assert len(hass.add_job.mock_calls) == 0 assert len(hass.add_job.mock_calls) == 0