From c7b910ca33bb6fdb90078d1adf1bda02b673ac84 Mon Sep 17 00:00:00 2001 From: Dave T <17680170+davet2001@users.noreply.github.com> Date: Wed, 22 Dec 2021 08:31:23 +0000 Subject: [PATCH] Use new enums in knx tests (#62513) * Use new enums in knx tests * Code review: Swap == for is --- tests/components/knx/test_binary_sensor.py | 13 ++++--------- tests/components/knx/test_scene.py | 11 ++++------- 2 files changed, 8 insertions(+), 16 deletions(-) diff --git a/tests/components/knx/test_binary_sensor.py b/tests/components/knx/test_binary_sensor.py index 5513cefcbb4..25a223e76c8 100644 --- a/tests/components/knx/test_binary_sensor.py +++ b/tests/components/knx/test_binary_sensor.py @@ -4,14 +4,9 @@ from unittest.mock import patch from homeassistant.components.knx.const import CONF_STATE_ADDRESS, CONF_SYNC_STATE from homeassistant.components.knx.schema import BinarySensorSchema -from homeassistant.const import ( - CONF_ENTITY_CATEGORY, - CONF_NAME, - ENTITY_CATEGORY_DIAGNOSTIC, - STATE_OFF, - STATE_ON, -) +from homeassistant.const import CONF_ENTITY_CATEGORY, CONF_NAME, STATE_OFF, STATE_ON from homeassistant.core import HomeAssistant, State +from homeassistant.helpers.entity import EntityCategory from homeassistant.helpers.entity_registry import ( async_get_registry as async_get_entity_registry, ) @@ -30,7 +25,7 @@ async def test_binary_sensor_entity_category(hass: HomeAssistant, knx: KNXTestKi { CONF_NAME: "test_normal", CONF_STATE_ADDRESS: "1/1/1", - CONF_ENTITY_CATEGORY: ENTITY_CATEGORY_DIAGNOSTIC, + CONF_ENTITY_CATEGORY: EntityCategory.DIAGNOSTIC, }, ] } @@ -42,7 +37,7 @@ async def test_binary_sensor_entity_category(hass: HomeAssistant, knx: KNXTestKi registry = await async_get_entity_registry(hass) entity = registry.async_get("binary_sensor.test_normal") - assert entity.entity_category == ENTITY_CATEGORY_DIAGNOSTIC + assert entity.entity_category is EntityCategory.DIAGNOSTIC async def test_binary_sensor(hass: HomeAssistant, knx: KNXTestKit): diff --git a/tests/components/knx/test_scene.py b/tests/components/knx/test_scene.py index c2f15df6f6c..37e4ac12728 100644 --- a/tests/components/knx/test_scene.py +++ b/tests/components/knx/test_scene.py @@ -2,12 +2,9 @@ from homeassistant.components.knx.const import KNX_ADDRESS from homeassistant.components.knx.schema import SceneSchema -from homeassistant.const import ( - CONF_ENTITY_CATEGORY, - CONF_NAME, - ENTITY_CATEGORY_DIAGNOSTIC, -) +from homeassistant.const import CONF_ENTITY_CATEGORY, CONF_NAME from homeassistant.core import HomeAssistant +from homeassistant.helpers.entity import EntityCategory from homeassistant.helpers.entity_registry import ( async_get_registry as async_get_entity_registry, ) @@ -24,7 +21,7 @@ async def test_activate_knx_scene(hass: HomeAssistant, knx: KNXTestKit): CONF_NAME: "test", SceneSchema.CONF_SCENE_NUMBER: 24, KNX_ADDRESS: "1/1/1", - CONF_ENTITY_CATEGORY: ENTITY_CATEGORY_DIAGNOSTIC, + CONF_ENTITY_CATEGORY: EntityCategory.DIAGNOSTIC, }, ] } @@ -33,7 +30,7 @@ async def test_activate_knx_scene(hass: HomeAssistant, knx: KNXTestKit): registry = await async_get_entity_registry(hass) entity = registry.async_get("scene.test") - assert entity.entity_category == ENTITY_CATEGORY_DIAGNOSTIC + assert entity.entity_category is EntityCategory.DIAGNOSTIC assert entity.unique_id == "1/1/1_24" await hass.services.async_call(