From c7bbba9d48f067e6a11532046191c5236ea56ac6 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Sun, 11 Oct 2020 11:12:27 -0500 Subject: [PATCH] Reduce icmplib ping timeout to match ping binary behavior (#41620) --- homeassistant/components/ping/binary_sensor.py | 1 + homeassistant/components/ping/device_tracker.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/homeassistant/components/ping/binary_sensor.py b/homeassistant/components/ping/binary_sensor.py index afbfe80b43f..98c36c01d98 100644 --- a/homeassistant/components/ping/binary_sensor.py +++ b/homeassistant/components/ping/binary_sensor.py @@ -143,6 +143,7 @@ class PingDataICMPLib(PingData): icmp_ping, self._ip_address, count=self._count, + timeout=1, id=async_get_next_ping_id(self.hass), ) ) diff --git a/homeassistant/components/ping/device_tracker.py b/homeassistant/components/ping/device_tracker.py index ea2d7a526e3..4139438bcfe 100644 --- a/homeassistant/components/ping/device_tracker.py +++ b/homeassistant/components/ping/device_tracker.py @@ -92,7 +92,7 @@ class HostICMPLib: ).result() return icmp_ping( - self.ip_address, count=PING_ATTEMPTS_COUNT, id=next_id + self.ip_address, count=PING_ATTEMPTS_COUNT, timeout=1, id=next_id ).is_alive def update(self, see):