jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-19 03:07:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve SmartThings OCF device info (#139547)

Browse Source
This commit is contained in:
Joost Lekkerkerker 2025-02-28 22:30:57 +01:00 committed by Bram Kragten
parent 8cc587d3a7
commit c7d89398a0
2 changed files with 14 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
homeassistant/components/smartthings/entity.py
View File

@ -2,7 +2,7 @@
from __future__ import annotations from __future__ import annotations
from typing import Any, cast from typing import Any
from pysmartthings import ( from pysmartthings import (
Attribute, Attribute,
@ -44,19 +44,13 @@ class SmartThingsEntity(Entity):
identifiers={(DOMAIN, device.device.device_id)}, identifiers={(DOMAIN, device.device.device_id)},
name=device.device.label, name=device.device.label,
) )
if (ocf := device.status[MAIN].get(Capability.OCF)) is not None: if (ocf := device.device.ocf) is not None:
self._attr_device_info.update( self._attr_device_info.update(
{ {
"manufacturer": cast( "manufacturer": ocf.manufacturer_name,
str | None, ocf[Attribute.MANUFACTURER_NAME].value "model": ocf.model_number.split("|")[0],
), "hw_version": ocf.hardware_version,
"model": cast(str | None, ocf[Attribute.MODEL_NUMBER].value), "sw_version": ocf.firmware_version,
"hw_version": cast(
str | None, ocf[Attribute.HARDWARE_VERSION].value
),
"sw_version": cast(
str | None, ocf[Attribute.OCF_FIRMWARE_VERSION].value
),
} }
) )

16
tests/components/smartthings/snapshots/test_init.ambr
View File

@ -219,7 +219,7 @@
'labels': set({ 'labels': set({
}), }),
'manufacturer': 'Samsung Electronics', 'manufacturer': 'Samsung Electronics',
'model': 'ARTIK051_KRAC_18K|10193441|60010132001111110200000000000000', 'model': 'ARTIK051_KRAC_18K',
'model_id': None, 'model_id': None,
'name': 'AC Office Granit', 'name': 'AC Office Granit',
'name_by_user': None, 'name_by_user': None,
@ -252,7 +252,7 @@
'labels': set({ 'labels': set({
}), }),
'manufacturer': 'Samsung Electronics', 'manufacturer': 'Samsung Electronics',
'model': 'ARA-WW-TP1-22-COMMON|10229641|60010523001511014600083200800000', 'model': 'ARA-WW-TP1-22-COMMON',
'model_id': None, 'model_id': None,
'name': 'Aire Dormitorio Principal', 'name': 'Aire Dormitorio Principal',
'name_by_user': None, 'name_by_user': None,
@ -285,7 +285,7 @@
'labels': set({ 'labels': set({
}), }),
'manufacturer': 'Samsung Electronics', 'manufacturer': 'Samsung Electronics',
'model': 'TP2X_DA-KS-MICROWAVE-0101X|40436241|50040100011411000200000000000000', 'model': 'TP2X_DA-KS-MICROWAVE-0101X',
'model_id': None, 'model_id': None,
'name': 'Microwave', 'name': 'Microwave',
'name_by_user': None, 'name_by_user': None,
@ -318,7 +318,7 @@
'labels': set({ 'labels': set({
}), }),
'manufacturer': 'Samsung Electronics', 'manufacturer': 'Samsung Electronics',
'model': 'TP2X_REF_20K|00115641|0004014D011411200103000020000000', 'model': 'TP2X_REF_20K',
'model_id': None, 'model_id': None,
'name': 'Refrigerator', 'name': 'Refrigerator',
'name_by_user': None, 'name_by_user': None,
@ -351,7 +351,7 @@
'labels': set({ 'labels': set({
}), }),
'manufacturer': 'Samsung Electronics', 'manufacturer': 'Samsung Electronics',
'model': 'powerbot_7000_17M|50016055|80010404011141000100000000000000', 'model': 'powerbot_7000_17M',
'model_id': None, 'model_id': None,
'name': 'Robot vacuum', 'name': 'Robot vacuum',
'name_by_user': None, 'name_by_user': None,
@ -384,7 +384,7 @@
'labels': set({ 'labels': set({
}), }),
'manufacturer': 'Samsung Electronics', 'manufacturer': 'Samsung Electronics',
'model': 'DA_DW_A51_20_COMMON|30007242|40010201001311000101000000000000', 'model': 'DA_DW_A51_20_COMMON',
'model_id': None, 'model_id': None,
'name': 'Dishwasher', 'name': 'Dishwasher',
'name_by_user': None, 'name_by_user': None,
@ -417,7 +417,7 @@
'labels': set({ 'labels': set({
}), }),
'manufacturer': 'Samsung Electronics', 'manufacturer': 'Samsung Electronics',
'model': 'DA_WM_A51_20_COMMON|20233741|3000000100111100020B000000000000', 'model': 'DA_WM_A51_20_COMMON',
'model_id': None, 'model_id': None,
'name': 'Dryer', 'name': 'Dryer',
'name_by_user': None, 'name_by_user': None,
@ -450,7 +450,7 @@
'labels': set({ 'labels': set({
}), }),
'manufacturer': 'Samsung Electronics', 'manufacturer': 'Samsung Electronics',
'model': 'DA_WM_TP2_20_COMMON|20233741|2001000100131100022B010000000000', 'model': 'DA_WM_TP2_20_COMMON',
'model_id': None, 'model_id': None,
'name': 'Washer', 'name': 'Washer',
'name_by_user': None, 'name_by_user': None,