jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-19 03:07:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Handle empty entity_id in the recorder filter (#121681)

Browse Source 
fixes #111745
This commit is contained in:
J. Nick Koston 2024-07-10 07:53:38 -07:00 committed by GitHub
parent 8b729e3c7d
commit c81d5a1ac2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
homeassistant/components/recorder/core.py
View File

@ -319,9 +319,8 @@ class Recorder(threading.Thread):
if event.event_type in exclude_event_types: if event.event_type in exclude_event_types:
return return
if ( if entity_filter is None or not (
entity_filter is None entity_id := event.data.get(ATTR_ENTITY_ID)
or (entity_id := event.data.get(ATTR_ENTITY_ID)) is None
): ):
queue_put(event) queue_put(event)
return return

17
tests/components/recorder/test_init.py
View File

@ -2700,3 +2700,20 @@ async def test_all_tables_use_default_table_args(hass: HomeAssistant) -> None:
"""Test that all tables use the default table args.""" """Test that all tables use the default table args."""
for table in db_schema.Base.metadata.tables.values(): for table in db_schema.Base.metadata.tables.values():
assert table.kwargs.items() >= db_schema._DEFAULT_TABLE_ARGS.items() assert table.kwargs.items() >= db_schema._DEFAULT_TABLE_ARGS.items()
async def test_empty_entity_id(
hass: HomeAssistant,
async_setup_recorder_instance: RecorderInstanceGenerator,
caplog: pytest.LogCaptureFixture,
) -> None:
"""Test the recorder can handle an empty entity_id."""
await async_setup_recorder_instance(
hass,
{
"exclude": {"domains": "hidden_domain"},
},
)
hass.bus.async_fire("hello", {"entity_id": ""})
await async_wait_recording_done(hass)
assert "Invalid entity ID" not in caplog.text