Remove test cases for task eager_start <3.12 (#114243)

This commit is contained in:
Marc Mueller 2024-03-26 15:52:38 +01:00 committed by GitHub
parent 53944b260c
commit c8260a5966
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 0 additions and 49 deletions

View File

@ -9,7 +9,6 @@ import functools
import gc import gc
import logging import logging
import os import os
import sys
from tempfile import TemporaryDirectory from tempfile import TemporaryDirectory
import threading import threading
import time import time
@ -334,9 +333,6 @@ async def test_async_create_task_schedule_coroutine() -> None:
assert len(hass.add_job.mock_calls) == 0 assert len(hass.add_job.mock_calls) == 0
@pytest.mark.skipif(
sys.version_info < (3, 12), reason="eager_start is only supported for Python 3.12"
)
async def test_async_create_task_eager_start_schedule_coroutine() -> None: async def test_async_create_task_eager_start_schedule_coroutine() -> None:
"""Test that we schedule coroutines and add jobs to the job pool.""" """Test that we schedule coroutines and add jobs to the job pool."""
hass = MagicMock(loop=MagicMock(wraps=asyncio.get_running_loop())) hass = MagicMock(loop=MagicMock(wraps=asyncio.get_running_loop()))
@ -350,24 +346,6 @@ async def test_async_create_task_eager_start_schedule_coroutine() -> None:
assert len(hass.add_job.mock_calls) == 0 assert len(hass.add_job.mock_calls) == 0
@pytest.mark.skipif(
sys.version_info >= (3, 12), reason="eager_start is not supported on < 3.12"
)
async def test_async_create_task_eager_start_fallback_schedule_coroutine() -> None:
"""Test that we schedule coroutines and add jobs to the job pool."""
hass = MagicMock(loop=MagicMock(wraps=asyncio.get_running_loop()))
async def job():
pass
ha.HomeAssistant.async_create_task(hass, job(), eager_start=True)
assert len(hass.loop.call_soon.mock_calls) == 1
# Should fallback to loop.create_task since 3.11 does
# not support eager_start
assert len(hass.loop.create_task.mock_calls) == 0
assert len(hass.add_job.mock_calls) == 0
async def test_async_create_task_schedule_coroutine_with_name() -> None: async def test_async_create_task_schedule_coroutine_with_name() -> None:
"""Test that we schedule coroutines and add jobs to the job pool with a name.""" """Test that we schedule coroutines and add jobs to the job pool with a name."""
hass = MagicMock(loop=MagicMock(wraps=asyncio.get_running_loop())) hass = MagicMock(loop=MagicMock(wraps=asyncio.get_running_loop()))

View File

@ -1,7 +1,6 @@
"""Tests for async util methods from Python source.""" """Tests for async util methods from Python source."""
import asyncio import asyncio
import sys
import time import time
from unittest.mock import MagicMock, Mock, patch from unittest.mock import MagicMock, Mock, patch
@ -271,7 +270,6 @@ async def test_callback_is_always_scheduled(hass: HomeAssistant) -> None:
mock_call_soon_threadsafe.assert_called_once() mock_call_soon_threadsafe.assert_called_once()
@pytest.mark.skipif(sys.version_info < (3, 12), reason="Test requires Python 3.12+")
async def test_create_eager_task_312(hass: HomeAssistant) -> None: async def test_create_eager_task_312(hass: HomeAssistant) -> None:
"""Test create_eager_task schedules a task eagerly in the event loop. """Test create_eager_task schedules a task eagerly in the event loop.
@ -294,28 +292,3 @@ async def test_create_eager_task_312(hass: HomeAssistant) -> None:
assert events == ["eager", "normal"] assert events == ["eager", "normal"]
await task1 await task1
await task2 await task2
@pytest.mark.skipif(sys.version_info >= (3, 12), reason="Test requires < Python 3.12")
async def test_create_eager_task_pre_312(hass: HomeAssistant) -> None:
"""Test create_eager_task schedules a task in the event loop.
For older python versions, the task is scheduled normally.
"""
events = []
async def _normal_task():
events.append("normal")
async def _eager_task():
events.append("eager")
task1 = hasync.create_eager_task(_eager_task())
task2 = asyncio.create_task(_normal_task())
assert events == []
await asyncio.sleep(0)
assert events == ["eager", "normal"]
await task1
await task2