From c899e2a662efdf3589e0c5482fec3a58e333a2fc Mon Sep 17 00:00:00 2001 From: Richard Mitchell Date: Fri, 19 Apr 2019 19:01:54 +0100 Subject: [PATCH] Name sensors correctly (#23208) * Hue motion senors are motion sensors, not presence sensors. * Name the sensors 'motion' instead of 'presence' - match the HA paradigm. --- homeassistant/components/hue/binary_sensor.py | 2 +- tests/components/hue/test_sensor_base.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/homeassistant/components/hue/binary_sensor.py b/homeassistant/components/hue/binary_sensor.py index 3286f185ea4..b9921a9a01f 100644 --- a/homeassistant/components/hue/binary_sensor.py +++ b/homeassistant/components/hue/binary_sensor.py @@ -5,7 +5,7 @@ from homeassistant.components.hue.sensor_base import ( GenericZLLSensor, async_setup_entry as shared_async_setup_entry) -PRESENCE_NAME_FORMAT = "{} presence" +PRESENCE_NAME_FORMAT = "{} motion" async def async_setup_entry(hass, config_entry, async_add_entities): diff --git a/tests/components/hue/test_sensor_base.py b/tests/components/hue/test_sensor_base.py index 99829c59666..38eb3d8c55b 100644 --- a/tests/components/hue/test_sensor_base.py +++ b/tests/components/hue/test_sensor_base.py @@ -391,7 +391,7 @@ async def test_sensors(hass, mock_bridge): assert len(hass.states.async_all()) == 6 presence_sensor_1 = hass.states.get( - 'binary_sensor.living_room_sensor_presence') + 'binary_sensor.living_room_sensor_motion') light_level_sensor_1 = hass.states.get( 'sensor.living_room_sensor_light_level') temperature_sensor_1 = hass.states.get( @@ -406,7 +406,7 @@ async def test_sensors(hass, mock_bridge): assert temperature_sensor_1.name == 'Living room sensor temperature' presence_sensor_2 = hass.states.get( - 'binary_sensor.kitchen_sensor_presence') + 'binary_sensor.kitchen_sensor_motion') light_level_sensor_2 = hass.states.get( 'sensor.kitchen_sensor_light_level') temperature_sensor_2 = hass.states.get( @@ -459,7 +459,7 @@ async def test_new_sensor_discovered(hass, mock_bridge): assert len(mock_bridge.mock_requests) == 2 assert len(hass.states.async_all()) == 9 - presence = hass.states.get('binary_sensor.bedroom_sensor_presence') + presence = hass.states.get('binary_sensor.bedroom_sensor_motion') assert presence is not None assert presence.state == 'on' temperature = hass.states.get('sensor.bedroom_sensor_temperature')