jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-18 18:57:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Manage unsupported sources on Samsung TV (#144221)

Browse Source
This commit is contained in:
Simone Chemelli 2025-05-06 13:20:04 +03:00 committed by GitHub
parent 57217b46ed
commit c9a9488ff5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 24 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
homeassistant/components/samsungtv/media_player.py
View File

@ -386,4 +386,8 @@ class SamsungTVDevice(SamsungTVEntity, MediaPlayerEntity):
await self._async_send_keys([SOURCES[source]]) await self._async_send_keys([SOURCES[source]])
return return
LOGGER.error("Unsupported source") raise HomeAssistantError(
translation_domain=DOMAIN,
translation_key="source_unsupported",
translation_placeholders={"entity": self.entity_id, "source": source},
)

3
homeassistant/components/samsungtv/strings.json
View File

@ -68,6 +68,9 @@
"service_unsupported": { "service_unsupported": {
"message": "Entity {entity} does not support this action." "message": "Entity {entity} does not support this action."
}, },
"source_unsupported": {
"message": "Entity {entity} does not support source {source}."
},
"error_set_volume": { "error_set_volume": {
"message": "Unable to set volume level on {host}: {error}" "message": "Unable to set volume level on {host}: {error}"
}, },

22
tests/components/samsungtv/test_media_player.py
View File

@ -1105,17 +1105,27 @@ async def test_select_source(hass: HomeAssistant, remote: Mock) -> None:
async def test_select_source_invalid_source(hass: HomeAssistant) -> None: async def test_select_source_invalid_source(hass: HomeAssistant) -> None:
"""Test for select_source with invalid source.""" """Test for select_source with invalid source."""
source = "INVALID"
with patch("homeassistant.components.samsungtv.bridge.Remote") as remote: with patch("homeassistant.components.samsungtv.bridge.Remote") as remote:
await setup_samsungtv_entry(hass, MOCK_CONFIG) await setup_samsungtv_entry(hass, MOCK_CONFIG)
remote.reset_mock() remote.reset_mock()
await hass.services.async_call( with pytest.raises(HomeAssistantError) as exc_info:
MP_DOMAIN, await hass.services.async_call(
SERVICE_SELECT_SOURCE, MP_DOMAIN,
{ATTR_ENTITY_ID: ENTITY_ID, ATTR_INPUT_SOURCE: "INVALID"}, SERVICE_SELECT_SOURCE,
True, {ATTR_ENTITY_ID: ENTITY_ID, ATTR_INPUT_SOURCE: source},
) True,
)
# control not called # control not called
assert remote.control.call_count == 0 assert remote.control.call_count == 0
assert exc_info.value.translation_domain == DOMAIN
assert exc_info.value.translation_key == "source_unsupported"
assert exc_info.value.translation_placeholders == {
"entity": ENTITY_ID,
"source": source,
}
@pytest.mark.usefixtures("rest_api") @pytest.mark.usefixtures("rest_api")